Skip to content

Commit 82f0303

Browse files
committed
node: e2e: Remove flaky label as device plugin reboot test is deflaked
With the device plugin node reboot test fixed, we can see in testgrid [node-kubelet-containerd-flaky](https://testgrid.k8s.io/sig-node-containerd#node-kubelet-containerd-flaky) that the test is passing consitently and we can remove the flaky label. With the test not flaky anymore, we can validate new PRs against it and ensure we don't cause regressions. Signed-off-by: Swati Sehgal <[email protected]>
1 parent 8294abc commit 82f0303

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/e2e_node/device_plugin_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,7 @@ func testDevicePluginNodeReboot(f *framework.Framework, pluginSockDir string) {
932932
// simulate node reboot scenario by removing pods using CRI before kubelet is started. In addition to that,
933933
// intentionally a scenario is created where after node reboot, application pods requesting devices appear before the device plugin pod
934934
// exposing those devices as resource has restarted. The expected behavior is that the application pod fails at admission time.
935-
framework.It("Does not keep device plugin assignments across node reboots if fails admission (no pod restart, no device plugin re-registration)", framework.WithFlaky(), func(ctx context.Context) {
935+
framework.It("Does not keep device plugin assignments across node reboots if fails admission (no pod restart, no device plugin re-registration)", func(ctx context.Context) {
936936
podRECMD := fmt.Sprintf("devs=$(ls /tmp/ | egrep '^Dev-[0-9]+$') && echo stub devices: $devs && sleep %s", sleepIntervalForever)
937937
pod1 := e2epod.NewPodClient(f).CreateSync(ctx, makeBusyboxPod(SampleDeviceResourceName, podRECMD))
938938
deviceIDRE := "stub devices: (Dev-[0-9]+)"

0 commit comments

Comments
 (0)