Skip to content

Commit 85d5b4b

Browse files
committed
Skip source IP preservation checks for Proxy-type load balancers
To be revisited
1 parent 79394a1 commit 85d5b4b

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

test/e2e/network/loadbalancer.go

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -927,11 +927,6 @@ var _ = common.SIGDescribe("LoadBalancers", feature.LoadBalancer, func() {
927927
})
928928

929929
var _ = common.SIGDescribe("LoadBalancers ExternalTrafficPolicy: Local", feature.LoadBalancer, framework.WithSlow(), func() {
930-
// FIXME: What are the expected semantics of requesting an
931-
// "ExternalTrafficPolicy: Local" service from a cloud provider that does not
932-
// support that? What are the expected semantics of "ExternalTrafficPolicy: Local"
933-
// on `IPMode: Proxy`-type LoadBalancers?
934-
935930
f := framework.NewDefaultFramework("esipp")
936931
f.NamespacePodSecurityLevel = admissionapi.LevelBaseline
937932
var loadBalancerCreateTimeout time.Duration
@@ -987,6 +982,14 @@ var _ = common.SIGDescribe("LoadBalancers ExternalTrafficPolicy: Local", feature
987982
framework.ExpectNoError(err)
988983
})
989984

985+
// FIXME: figure out the actual expected semantics for
986+
// "ExternalTrafficPolicy: Local" + "IPMode: Proxy".
987+
// https://issues.k8s.io/123714
988+
ingress := &svc.Status.LoadBalancer.Ingress[0]
989+
if ingress.IP == "" || (ingress.IPMode != nil && *ingress.IPMode == v1.LoadBalancerIPModeProxy) {
990+
e2eskipper.Skipf("LoadBalancer uses 'Proxy' IPMode")
991+
}
992+
990993
svcTCPPort := int(svc.Spec.Ports[0].Port)
991994
ingressIP := e2eservice.GetIngressPoint(&svc.Status.LoadBalancer.Ingress[0])
992995

@@ -1133,6 +1136,14 @@ var _ = common.SIGDescribe("LoadBalancers ExternalTrafficPolicy: Local", feature
11331136
framework.ExpectNoError(err)
11341137
})
11351138

1139+
// FIXME: figure out the actual expected semantics for
1140+
// "ExternalTrafficPolicy: Local" + "IPMode: Proxy".
1141+
// https://issues.k8s.io/123714
1142+
ingress := &svc.Status.LoadBalancer.Ingress[0]
1143+
if ingress.IP == "" || (ingress.IPMode != nil && *ingress.IPMode == v1.LoadBalancerIPModeProxy) {
1144+
e2eskipper.Skipf("LoadBalancer uses 'Proxy' IPMode")
1145+
}
1146+
11361147
ingressIP := e2eservice.GetIngressPoint(&svc.Status.LoadBalancer.Ingress[0])
11371148
port := strconv.Itoa(int(svc.Spec.Ports[0].Port))
11381149
ipPort := net.JoinHostPort(ingressIP, port)

0 commit comments

Comments
 (0)