api: remove obsolete validation of deterministic claim name

When replacing the deterministic ResourceClaim name with a generated one this
particular piece of the original validation was incorrectly left in place.
It's not required anymore that "<pod name>-<claim name in pod spec>" is a valid
ResourceClaim name.

Author: pohly

pkg/apis/core/validation/validation.go

@@ -3017,15 +3017,7 @@ func validatePodResourceClaim(podMeta *metav1.ObjectMeta, claim core.PodResource
 	} else if podClaimNames.Has(claim.Name) {
 		allErrs = append(allErrs, field.Duplicate(fldPath.Child("name"), claim.Name))
 	} else {
-		nameErrs := ValidateDNS1123Label(claim.Name, fldPath.Child("name"))
-		if len(nameErrs) > 0 {
-			allErrs = append(allErrs, nameErrs...)
-		} else if podMeta != nil && claim.ResourceClaimTemplateName != nil {
-			claimName := podMeta.Name + "-" + claim.Name
-			for _, detail := range ValidateResourceClaimName(claimName, false) {
-				allErrs = append(allErrs, field.Invalid(fldPath.Child("name"), claimName, "final ResourceClaim name: "+detail))
-			}
-		}
+		allErrs = append(allErrs, ValidateDNS1123Label(claim.Name, fldPath.Child("name"))...)
 		podClaimNames.Insert(claim.Name)
 	}
 	if claim.ResourceClaimName != nil && claim.ResourceClaimTemplateName != nil {

pkg/apis/core/validation/validation_test.go

@@ -25860,9 +25860,6 @@ func TestValidateDynamicResourceAllocation(t *testing.T) {
 	shortPodName := &metav1.ObjectMeta{
 		Name: "some-pod",
 	}
-	brokenPodName := &metav1.ObjectMeta{
-		Name: ".dot.com",
-	}
 	goodClaimTemplate := core.PodSpec{
 		Containers:    []core.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: "File", Resources: core.ResourceRequirements{Claims: []core.ResourceClaim{{Name: "my-claim-template"}}}}},
 		RestartPolicy: core.RestartPolicyAlways,
@@ -26046,27 +26043,6 @@ func TestValidateDynamicResourceAllocation(t *testing.T) {
 			t.Errorf("expected failure for %q", k)
 		}
 	}
-
-	t.Run("generated-claim-name", func(t *testing.T) {
-		for _, spec := range []*core.PodSpec{&goodClaimTemplate, &goodClaimReference} {
-			claimName := spec.ResourceClaims[0].Name
-			t.Run(claimName, func(t *testing.T) {
-				for _, podMeta := range []*metav1.ObjectMeta{shortPodName, brokenPodName} {
-					t.Run(podMeta.Name, func(t *testing.T) {
-						errs := ValidatePodSpec(spec, podMeta, field.NewPath("field"), PodValidationOptions{})
-						// Only one out of the four combinations fails.
-						expectError := spec == &goodClaimTemplate && podMeta == brokenPodName
-						if expectError && len(errs) == 0 {
-							t.Error("did not get the expected failure")
-						}
-						if !expectError && len(errs) > 0 {
-							t.Errorf("unexpected failures: %+v", errs)
-						}
-					})
-				}
-			})
-		}
-	})
 }
 
 func TestValidateLoadBalancerStatus(t *testing.T) {