Skip to content

Commit 8fcb4b5

Browse files
committed
comment we keep storing v1beta1 by default to handle upgrades
1 parent 3606d52 commit 8fcb4b5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/kubeapiserver/default_storage_factory_builder.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ func NewStorageFactoryConfig() *StorageFactoryConfig {
7474
// TODO (https://github.com/kubernetes/kubernetes/issues/108451): remove the override in 1.25.
7575
// apisstorage.Resource("csistoragecapacities").WithVersion("v1beta1"),
7676
coordination.Resource("leasecandidates").WithVersion("v1alpha2"),
77+
// TODO(aojea) ipaddresses and servicecidrs are v1 in 1.33
78+
// remove them in 1.34 when all apiserver understand the v1 version.
7779
networking.Resource("ipaddresses").WithVersion("v1beta1"),
7880
networking.Resource("servicecidrs").WithVersion("v1beta1"),
7981
admissionregistration.Resource("mutatingadmissionpolicies").WithVersion("v1alpha1"),

0 commit comments

Comments
 (0)