Skip to content

Commit 905fdda

Browse files
authored
Merge pull request kubernetes#125739 from seans3/ignore-portforward-leak
Ignore reported goroutine leak during SPDY shutdown
2 parents 152a0ca + 5ba8773 commit 905fdda

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

test/integration/framework/etcd.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,14 @@ func EtcdMain(tests func() int) {
207207
// Both names occurred in practice.
208208
goleak.IgnoreTopFunction("k8s.io/kubernetes/vendor/gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"),
209209
goleak.IgnoreTopFunction("gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"),
210+
// If there is an error during connection shutdown, SPDY keeps a
211+
// goroutine around for ten minutes, which gets reported as a leak
212+
// (the goroutine is cleaned up after the ten minutes).
213+
//
214+
// https://github.com/kubernetes/kubernetes/blob/master/vendor/github.com/moby/spdystream/connection.go#L732-L744
215+
//
216+
// Ignore this reported leak.
217+
goleak.IgnoreTopFunction("github.com/moby/spdystream.(*Connection).shutdown"),
210218
)
211219

212220
stop, err := startEtcd(nil)

0 commit comments

Comments
 (0)