Merge pull request kubernetes#120454 from pohly/golangci-lint-hint-deprecated

k8s-ci-robot · web-flow · commit 9068bec08e7f · 2023-09-08T00:32:25.000-07:00
golangci-lint: warn about deprecated APIs only as hints
diff --git a/hack/golangci-strict.yaml b/hack/golangci-strict.yaml
@@ -83,6 +83,14 @@ issues:
         - gosimple
       text: "S1033: unnecessary guard around call to delete"
 
+    # Didn't make it into https://github.com/kubernetes/kubernetes/issues/117288.
+    # Discussion on Slack concluded that "it's hard to have a universal policy for all
+    # functions marked deprecated" and thus this can only be a hint which must
+    # be considered on a case-by-case basis.
+    - linters:
+        - staticcheck
+      text: "SA1019: .*is deprecated"
+
     # https://github.com/kubernetes/kubernetes/issues/117288#issuecomment-1507030071
     - linters:
         - stylecheck
diff --git a/hack/golangci.yaml b/hack/golangci.yaml
@@ -89,6 +89,14 @@ issues:
         - gosimple
       text: "S1033: unnecessary guard around call to delete"
 
+    # Didn't make it into https://github.com/kubernetes/kubernetes/issues/117288.
+    # Discussion on Slack concluded that "it's hard to have a universal policy for all
+    # functions marked deprecated" and thus this can only be a hint which must
+    # be considered on a case-by-case basis.
+    - linters:
+        - staticcheck
+      text: "SA1019: .*is deprecated"
+
     # https://github.com/kubernetes/kubernetes/issues/117288#issuecomment-1507030071
     - linters:
         - stylecheck
diff --git a/hack/golangci.yaml.in b/hack/golangci.yaml.in
@@ -94,6 +94,14 @@ issues:
         - gosimple
       text: "S1033: unnecessary guard around call to delete"
 
+    # Didn't make it into https://github.com/kubernetes/kubernetes/issues/117288.
+    # Discussion on Slack concluded that "it's hard to have a universal policy for all
+    # functions marked deprecated" and thus this can only be a hint which must
+    # be considered on a case-by-case basis.
+    - linters:
+        - staticcheck
+      text: "SA1019: .*is deprecated"
+
     # https://github.com/kubernetes/kubernetes/issues/117288#issuecomment-1507030071
     - linters:
         - stylecheck
