Skip to content

Commit 95c7621

Browse files
authored
Merge pull request kubernetes#125755 from saschagrunert/named-param-service
Make CRI service interface function arguments consistent
2 parents 24478e0 + 4411a07 commit 95c7621

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

staging/src/k8s.io/cri-api/pkg/apis/services.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ type ContainerManager interface {
5151
// If command exits with a non-zero exit code, an error is returned.
5252
ExecSync(ctx context.Context, containerID string, cmd []string, timeout time.Duration) (stdout []byte, stderr []byte, err error)
5353
// Exec prepares a streaming endpoint to execute a command in the container, and returns the address.
54-
Exec(context.Context, *runtimeapi.ExecRequest) (*runtimeapi.ExecResponse, error)
54+
Exec(ctx context.Context, request *runtimeapi.ExecRequest) (*runtimeapi.ExecResponse, error)
5555
// Attach prepares a streaming endpoint to attach to a running container, and returns the address.
5656
Attach(ctx context.Context, req *runtimeapi.AttachRequest) (*runtimeapi.AttachResponse, error)
5757
// ReopenContainerLog asks runtime to reopen the stdout/stderr log file
@@ -81,7 +81,7 @@ type PodSandboxManager interface {
8181
// ListPodSandbox returns a list of Sandbox.
8282
ListPodSandbox(ctx context.Context, filter *runtimeapi.PodSandboxFilter) ([]*runtimeapi.PodSandbox, error)
8383
// PortForward prepares a streaming endpoint to forward ports from a PodSandbox, and returns the address.
84-
PortForward(context.Context, *runtimeapi.PortForwardRequest) (*runtimeapi.PortForwardResponse, error)
84+
PortForward(ctx context.Context, request *runtimeapi.PortForwardRequest) (*runtimeapi.PortForwardResponse, error)
8585
}
8686

8787
// ContainerStatsManager contains methods for retrieving the container

0 commit comments

Comments
 (0)