Skip to content

Commit 960e702

Browse files
committed
flake(apiserver): fix TestReconcilerAPIServerLeaseMultiCombined
1 parent 1a16c2d commit 960e702

File tree

1 file changed

+14
-25
lines changed

1 file changed

+14
-25
lines changed

test/integration/controlplane/kube_apiserver_test.go

Lines changed: 14 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424
"net/http"
2525
"reflect"
2626
"strings"
27-
"sync"
2827
"testing"
2928
"time"
3029

@@ -440,22 +439,16 @@ func testReconcilersAPIServerLease(t *testing.T, leaseCount int, apiServerCount
440439

441440
instanceOptions := kubeapiservertesting.NewDefaultTestServerOptions()
442441

443-
wg := sync.WaitGroup{}
444442
// 1. start apiServerCount api servers
445443
for i := 0; i < apiServerCount; i++ {
446444
// start count api server
447-
wg.Add(1)
448-
go func(i int) {
449-
defer wg.Done()
450-
server := kubeapiservertesting.StartTestServerOrDie(t, instanceOptions, []string{
451-
"--endpoint-reconciler-type", "master-count",
452-
"--advertise-address", fmt.Sprintf("10.0.1.%v", i+1),
453-
"--apiserver-count", fmt.Sprintf("%v", apiServerCount),
454-
}, etcd)
455-
apiServerCountServers[i] = server
456-
}(i)
457-
}
458-
wg.Wait()
445+
server := kubeapiservertesting.StartTestServerOrDie(t, instanceOptions, []string{
446+
"--endpoint-reconciler-type", "master-count",
447+
"--advertise-address", fmt.Sprintf("10.0.1.%v", i+1),
448+
"--apiserver-count", fmt.Sprintf("%v", apiServerCount),
449+
}, etcd)
450+
apiServerCountServers[i] = server
451+
}
459452

460453
// 2. verify API Server count servers have registered
461454
if err := wait.PollImmediate(3*time.Second, 2*time.Minute, func() (bool, error) {
@@ -476,18 +469,14 @@ func testReconcilersAPIServerLease(t *testing.T, leaseCount int, apiServerCount
476469

477470
// 3. start lease api servers
478471
for i := 0; i < leaseCount; i++ {
479-
wg.Add(1)
480-
go func(i int) {
481-
defer wg.Done()
482-
options := []string{
483-
"--endpoint-reconciler-type", "lease",
484-
"--advertise-address", fmt.Sprintf("10.0.1.%v", i+10),
485-
}
486-
server := kubeapiservertesting.StartTestServerOrDie(t, instanceOptions, options, etcd)
487-
leaseServers[i] = server
488-
}(i)
472+
options := []string{
473+
"--endpoint-reconciler-type", "lease",
474+
"--advertise-address", fmt.Sprintf("10.0.1.%v", i+10),
475+
}
476+
server := kubeapiservertesting.StartTestServerOrDie(t, instanceOptions, options, etcd)
477+
leaseServers[i] = server
489478
}
490-
wg.Wait()
479+
491480
defer func() {
492481
for i := 0; i < leaseCount; i++ {
493482
leaseServers[i].TearDownFn()

0 commit comments

Comments
 (0)