Skip to content

Commit 9aa0475

Browse files
authored
Merge pull request kubernetes#118463 from testwill/replace_loop
chore: slice replace loop
2 parents cdd20ee + 1d9eed9 commit 9aa0475

File tree

4 files changed

+5
-15
lines changed

4 files changed

+5
-15
lines changed

pkg/scheduler/framework/plugins/dynamicresources/dynamicresources_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -640,9 +640,7 @@ func (tc *testContext) verify(t *testing.T, expected result, initialObjects []me
640640
assert.Equal(t, expected.status, status)
641641
objects := tc.listAll(t)
642642
wantObjects := update(t, initialObjects, expected.changes)
643-
for _, add := range expected.added {
644-
wantObjects = append(wantObjects, add)
645-
}
643+
wantObjects = append(wantObjects, expected.added...)
646644
for _, remove := range expected.removed {
647645
for i, obj := range wantObjects {
648646
// This is a bit relaxed (no GVR comparison, no UID

plugin/pkg/admission/limitranger/admission.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,7 @@ func (l *LimitRanger) GetLimitRanges(a admission.Attributes) ([]*corev1.LimitRan
186186
}
187187
lruEntry := lruItemObj.(liveLookupEntry)
188188

189-
for i := range lruEntry.items {
190-
items = append(items, lruEntry.items[i])
191-
}
189+
items = append(items, lruEntry.items...)
192190

193191
}
194192

test/e2e/network/netpol/policies.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ func SetSpecIngressRules(rules ...networkingv1.NetworkPolicyIngressRule) SetFunc
7979
policy.Spec.Ingress = []networkingv1.NetworkPolicyIngressRule{}
8080
policy.Spec.PolicyTypes = append(policy.Spec.PolicyTypes, networkingv1.PolicyTypeIngress)
8181
}
82-
for _, rule := range rules {
83-
policy.Spec.Ingress = append(policy.Spec.Ingress, rule)
84-
}
82+
policy.Spec.Ingress = append(policy.Spec.Ingress, rules...)
8583
}
8684
}
8785

@@ -91,8 +89,6 @@ func SetSpecEgressRules(rules ...networkingv1.NetworkPolicyEgressRule) SetFunc {
9189
policy.Spec.Egress = []networkingv1.NetworkPolicyEgressRule{}
9290
policy.Spec.PolicyTypes = append(policy.Spec.PolicyTypes, networkingv1.PolicyTypeEgress)
9391
}
94-
for _, rule := range rules {
95-
policy.Spec.Egress = append(policy.Spec.Egress, rule)
96-
}
92+
policy.Spec.Egress = append(policy.Spec.Egress, rules...)
9793
}
9894
}

test/e2e_node/memory_manager_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,7 @@ func updateKubeletConfigWithMemoryManagerParams(initialCfg *kubeletconfig.Kubele
216216
if initialCfg.ReservedMemory == nil {
217217
initialCfg.ReservedMemory = []kubeletconfig.MemoryReservation{}
218218
}
219-
for _, memoryReservation := range params.systemReservedMemory {
220-
initialCfg.ReservedMemory = append(initialCfg.ReservedMemory, memoryReservation)
221-
}
219+
initialCfg.ReservedMemory = append(initialCfg.ReservedMemory, params.systemReservedMemory...)
222220
}
223221

224222
func getAllNUMANodes() []int {

0 commit comments

Comments
 (0)