Merge pull request kubernetes#128085 from sttts/sttts-volume-flake

k8s-ci-robot · web-flow · commit 9b56413d56a9 · 2024-10-15T20:43:11.000+01:00
volume: fix TestVolumePluginMultiThreaded unit test flake
diff --git a/pkg/volume/plugins_test.go b/pkg/volume/plugins_test.go
@@ -198,14 +198,14 @@ func TestVolumePluginMultiThreaded(t *testing.T) {
 	assert.Equal(t, int32(0), totalErrors.Load())
 
 	for i := 0; i < 100; i++ {
+		wg.Add(1)
 		go func() {
 			defer wg.Done()
 			_, err := vpm.FindPluginBySpec(volumeSpec)
 			if err != nil {
 				totalErrors.Add(1)
 			}
 		}()
-		wg.Add(1)
 	}
 	wg.Wait()
 

Original file line number	Diff line number	Diff line change
`@@ -198,14 +198,14 @@ func TestVolumePluginMultiThreaded(t *testing.T) {`
`198`	`198`	`assert.Equal(t, int32(0), totalErrors.Load())`
`199`	`199`
`200`	`200`	`for i := 0; i < 100; i++ {`
	`201`	`+ wg.Add(1)`
`201`	`202`	`go func() {`
`202`	`203`	`defer wg.Done()`
`203`	`204`	`_, err := vpm.FindPluginBySpec(volumeSpec)`
`204`	`205`	`if err != nil {`
`205`	`206`	`totalErrors.Add(1)`
`206`	`207`	`}`
`207`	`208`	`}()`
`208`		`- wg.Add(1)`
`209`	`209`	`}`
`210`	`210`	`wg.Wait()`
`211`	`211`