Skip to content

Commit 9e2075b

Browse files
authored
Merge pull request kubernetes#125189 from mimowo/improve-ready-comment
Improve the Job API comment for ready field
2 parents d8b33e3 + 551464f commit 9e2075b

File tree

7 files changed

+10
-9
lines changed

7 files changed

+10
-9
lines changed

api/openapi-spec/swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/openapi-spec/v3/apis__batch__v1_openapi.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@
459459
"type": "string"
460460
},
461461
"ready": {
462-
"description": "The number of pods which have a Ready condition.",
462+
"description": "The number of active pods which have a Ready condition and are not terminating (without a deletionTimestamp).",
463463
"format": "int32",
464464
"type": "integer"
465465
},

pkg/apis/batch/types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,8 @@ type JobStatus struct {
537537
// +optional
538538
Terminating *int32
539539

540-
// The number of active pods which have a Ready condition.
540+
// The number of active pods which have a Ready condition and are not
541+
// terminating (without a deletionTimestamp).
541542
// +optional
542543
Ready *int32
543544

pkg/generated/openapi/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/batch/v1/generated.proto

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/batch/v1/types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -597,8 +597,8 @@ type JobStatus struct {
597597
// +optional
598598
UncountedTerminatedPods *UncountedTerminatedPods `json:"uncountedTerminatedPods,omitempty" protobuf:"bytes,8,opt,name=uncountedTerminatedPods"`
599599

600-
// The number of pods which have a Ready condition.
601-
// +optional
600+
// The number of active pods which have a Ready condition and are not
601+
// terminating (without a deletionTimestamp).
602602
Ready *int32 `json:"ready,omitempty" protobuf:"varint,9,opt,name=ready"`
603603
}
604604

staging/src/k8s.io/api/batch/v1/types_swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)