Skip to content

Commit 9f26291

Browse files
authored
Merge pull request kubernetes#129940 from vinayakankugoyal/gen
cleanup: Remove unused service account creation from node_authn.go
2 parents 6487606 + 453e22a commit 9f26291

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

test/e2e/auth/node_authn.go

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ import (
2323
"strconv"
2424

2525
v1 "k8s.io/api/core/v1"
26-
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2726
"k8s.io/kubernetes/pkg/cluster/ports"
28-
"k8s.io/kubernetes/test/e2e/feature"
2927
"k8s.io/kubernetes/test/e2e/framework"
3028
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3129
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
@@ -36,7 +34,7 @@ import (
3634
"github.com/onsi/gomega"
3735
)
3836

39-
var _ = SIGDescribe(feature.NodeAuthenticator, func() {
37+
var _ = SIGDescribe("NodeAuthenticator", func() {
4038

4139
f := framework.NewDefaultFramework("node-authn")
4240
f.NamespacePodSecurityLevel = admissionapi.LevelBaseline
@@ -68,18 +66,6 @@ var _ = SIGDescribe(feature.NodeAuthenticator, func() {
6866
})
6967

7068
ginkgo.It("The kubelet can delegate ServiceAccount tokens to the API server", func(ctx context.Context) {
71-
ginkgo.By("create a new ServiceAccount for authentication")
72-
trueValue := true
73-
newSA := &v1.ServiceAccount{
74-
ObjectMeta: metav1.ObjectMeta{
75-
Namespace: ns,
76-
Name: "node-auth-newsa",
77-
},
78-
AutomountServiceAccountToken: &trueValue,
79-
}
80-
_, err := f.ClientSet.CoreV1().ServiceAccounts(ns).Create(ctx, newSA, metav1.CreateOptions{})
81-
framework.ExpectNoError(err, "failed to create service account (%s:%s)", ns, newSA.Name)
82-
8369
pod := createNodeAuthTestPod(ctx, f)
8470

8571
for _, nodeIP := range nodeIPs {

test/e2e/feature/feature.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,9 +311,6 @@ var (
311311
// Testing node allocatable validations
312312
NodeAllocatable = framework.WithFeature(framework.ValidFeatures.Add("NodeAllocatable"))
313313

314-
// TODO: document the feature (owning SIG, when to use this feature for a test)
315-
NodeAuthenticator = framework.WithFeature(framework.ValidFeatures.Add("NodeAuthenticator"))
316-
317314
// Owner: sig-node
318315
// Node Problem Detect e2e tests in tree.
319316
NodeProblemDetector = framework.WithFeature(framework.ValidFeatures.Add("NodeProblemDetector"))

0 commit comments

Comments
 (0)