Skip to content

Commit 9f7843b

Browse files
committed
remove lister from test
1 parent e93016b commit 9f7843b

File tree

1 file changed

+3
-27
lines changed

1 file changed

+3
-27
lines changed

pkg/scheduler/framework/plugins/volumezone/volume_zone_test.go

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import (
3434
"k8s.io/kubernetes/pkg/scheduler/internal/cache"
3535
st "k8s.io/kubernetes/pkg/scheduler/testing"
3636
tf "k8s.io/kubernetes/pkg/scheduler/testing/framework"
37-
"k8s.io/utils/ptr"
3837
)
3938

4039
func createPodWithVolume(pod, pvc string) *v1.Pod {
@@ -542,29 +541,6 @@ func TestWithBinding(t *testing.T) {
542541
}
543542

544543
func TestIsSchedulableAfterPersistentVolumeClaimAdded(t *testing.T) {
545-
pvLister := tf.PersistentVolumeLister{
546-
{
547-
ObjectMeta: metav1.ObjectMeta{Name: "Vol_1", Labels: map[string]string{v1.LabelFailureDomainBetaZone: "us-west1-a"}},
548-
},
549-
}
550-
551-
pvcLister := tf.PersistentVolumeClaimLister{
552-
{
553-
ObjectMeta: metav1.ObjectMeta{Name: "PVC_1", Namespace: "default"},
554-
Spec: v1.PersistentVolumeClaimSpec{VolumeName: "Vol_1"},
555-
},
556-
{
557-
ObjectMeta: metav1.ObjectMeta{Name: "PVC_2", Namespace: "default"},
558-
Spec: v1.PersistentVolumeClaimSpec{StorageClassName: ptr.To("SC_1")},
559-
},
560-
}
561-
562-
scLister := tf.StorageClassLister{
563-
{
564-
ObjectMeta: metav1.ObjectMeta{Name: "SC_1"},
565-
},
566-
}
567-
568544
testcases := map[string]struct {
569545
pod *v1.Pod
570546
oldObj, newObj interface{}
@@ -639,9 +615,9 @@ func TestIsSchedulableAfterPersistentVolumeClaimAdded(t *testing.T) {
639615
t.Run(name, func(t *testing.T) {
640616
logger, _ := ktesting.NewTestContext(t)
641617
p := &VolumeZone{
642-
pvLister,
643-
pvcLister,
644-
scLister,
618+
nil,
619+
nil,
620+
nil,
645621
}
646622

647623
got, err := p.isSchedulableAfterPersistentVolumeClaimChange(logger, tc.pod, tc.oldObj, tc.newObj)

0 commit comments

Comments
 (0)