Added proper validation msg when non-sidecar containers are resized

vivzbansal · vivzbansal · commit a0d3cb0a2c74 · 2025-01-27T19:42:13.000Z
diff --git a/pkg/apis/core/validation/validation.go b/pkg/apis/core/validation/validation.go
@@ -5665,6 +5665,13 @@ func ValidatePodResize(newPod, oldPod *core.Pod, opts PodValidationOptions) fiel
 			newInitContainers = append(newInitContainers, container)
 		}
 		originalCPUMemPodSpec.InitContainers = newInitContainers
+		if !apiequality.Semantic.DeepEqual(originalCPUMemPodSpec.InitContainers, oldPod.Spec.InitContainers) {
+			// This likely means that the user has modified non-sidecar container resources.
+			specDiff := cmp.Diff(oldPod.Spec.InitContainers, originalCPUMemPodSpec.InitContainers)
+			errs := field.Forbidden(specPath, fmt.Sprintf("cpu and memory resources for only sidecar containers are mutable\n%v", specDiff))
+			allErrs = append(allErrs, errs)
+			return allErrs
+		}
 	}
 
 	if !apiequality.Semantic.DeepEqual(originalCPUMemPodSpec, oldPod.Spec) {

Original file line number	Diff line number	Diff line change
`@@ -5665,6 +5665,13 @@ func ValidatePodResize(newPod, oldPod *core.Pod, opts PodValidationOptions) fiel`
`5665`	`5665`	`newInitContainers = append(newInitContainers, container)`
`5666`	`5666`	`}`
`5667`	`5667`	`originalCPUMemPodSpec.InitContainers = newInitContainers`
	`5668`	`+ if !apiequality.Semantic.DeepEqual(originalCPUMemPodSpec.InitContainers, oldPod.Spec.InitContainers) {`
	`5669`	`+ // This likely means that the user has modified non-sidecar container resources.`
	`5670`	`+ specDiff := cmp.Diff(oldPod.Spec.InitContainers, originalCPUMemPodSpec.InitContainers)`
	`5671`	`+ errs := field.Forbidden(specPath, fmt.Sprintf("cpu and memory resources for only sidecar containers are mutable\n%v", specDiff))`
	`5672`	`+ allErrs = append(allErrs, errs)`
	`5673`	`+ return allErrs`
	`5674`	`+ }`
`5668`	`5675`	`}`
`5669`	`5676`
`5670`	`5677`	`if !apiequality.Semantic.DeepEqual(originalCPUMemPodSpec, oldPod.Spec) {`