Skip to content

Commit a517b4d

Browse files
committed
Fix the comment for the Job managedBy field
1 parent c7c4039 commit a517b4d

File tree

7 files changed

+10
-7
lines changed

7 files changed

+10
-7
lines changed

api/openapi-spec/swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/openapi-spec/v3/apis__batch__v1_openapi.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@
345345
"type": "integer"
346346
},
347347
"managedBy": {
348-
"description": "ManagedBy field indicates the controller that manages a Job. The k8s Job controller reconciles jobs which don't have this field at all or the field value is the reserved string `kubernetes.io/job-controller`, but skips reconciling Jobs with a custom value for this field. The value must be a valid domain-prefixed path (e.g. acme.io/foo) - all characters before the first \"/\" must be a valid subdomain as defined by RFC 1123. All characters trailing the first \"/\" must be valid HTTP Path characters as defined by RFC 3986. The value cannot exceed 64 characters.\n\nThis field is alpha-level. The job controller accepts setting the field when the feature gate JobManagedBy is enabled (disabled by default).",
348+
"description": "ManagedBy field indicates the controller that manages a Job. The k8s Job controller reconciles jobs which don't have this field at all or the field value is the reserved string `kubernetes.io/job-controller`, but skips reconciling Jobs with a custom value for this field. The value must be a valid domain-prefixed path (e.g. acme.io/foo) - all characters before the first \"/\" must be a valid subdomain as defined by RFC 1123. All characters trailing the first \"/\" must be valid HTTP Path characters as defined by RFC 3986. The value cannot exceed 63 characters. This field is immutable.\n\nThis field is alpha-level. The job controller accepts setting the field when the feature gate JobManagedBy is enabled (disabled by default).",
349349
"type": "string"
350350
},
351351
"manualSelector": {

pkg/apis/batch/types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,8 @@ type JobSpec struct {
476476
// The value must be a valid domain-prefixed path (e.g. acme.io/foo) -
477477
// all characters before the first "/" must be a valid subdomain as defined
478478
// by RFC 1123. All characters trailing the first "/" must be valid HTTP Path
479-
// characters as defined by RFC 3986. The value cannot exceed 64 characters.
479+
// characters as defined by RFC 3986. The value cannot exceed 63 characters.
480+
// This field is immutable.
480481
//
481482
// This field is alpha-level. The job controller accepts setting the field
482483
// when the feature gate JobManagedBy is enabled (disabled by default).

pkg/generated/openapi/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/batch/v1/generated.proto

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/batch/v1/types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,8 @@ type JobSpec struct {
477477
// The value must be a valid domain-prefixed path (e.g. acme.io/foo) -
478478
// all characters before the first "/" must be a valid subdomain as defined
479479
// by RFC 1123. All characters trailing the first "/" must be valid HTTP Path
480-
// characters as defined by RFC 3986. The value cannot exceed 64 characters.
480+
// characters as defined by RFC 3986. The value cannot exceed 63 characters.
481+
// This field is immutable.
481482
//
482483
// This field is alpha-level. The job controller accepts setting the field
483484
// when the feature gate JobManagedBy is enabled (disabled by default).

staging/src/k8s.io/api/batch/v1/types_swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)