fix: add feature-gate is disabled unit tests

Author: Phaow

plugin/pkg/admission/storage/storageobjectinuseprotection/admission_test.go

@@ -73,64 +73,84 @@ func TestAdmit(t *testing.T) {
 	vacWithFinalizer.Finalizers = []string{volumeutil.VACProtectionFinalizer}
 
 	tests := []struct {
-		name           string
-		resource       schema.GroupVersionResource
-		object         runtime.Object
-		expectedObject runtime.Object
-		namespace      string
+		name                 string
+		resource             schema.GroupVersionResource
+		object               runtime.Object
+		expectedObject       runtime.Object
+		namespace            string
+		enableVacFeatureGate bool
 	}{
 		{
 			"persistentvolumeclaims: create -> add finalizer",
 			api.SchemeGroupVersion.WithResource("persistentvolumeclaims"),
 			claim,
 			claimWithFinalizer,
 			claim.Namespace,
+			false,
 		},
 		{
 			"persistentvolumeclaims: finalizer already exists -> no new finalizer",
 			api.SchemeGroupVersion.WithResource("persistentvolumeclaims"),
 			claimWithFinalizer,
 			claimWithFinalizer,
 			claimWithFinalizer.Namespace,
+			false,
 		},
 		{
 			"persistentvolumes: create -> add finalizer",
 			api.SchemeGroupVersion.WithResource("persistentvolumes"),
 			pv,
 			pvWithFinalizer,
 			pv.Namespace,
+			false,
 		},
 		{
 			"persistentvolumes: finalizer already exists -> no new finalizer",
 			api.SchemeGroupVersion.WithResource("persistentvolumes"),
 			pvWithFinalizer,
 			pvWithFinalizer,
 			pvWithFinalizer.Namespace,
+			false,
 		},
 		{
-			"volumeattributesclasses: create -> add finalizer",
+			"volumeattributesclasses VacFeatureGate disabled: create -> no finalizer added",
 			storageapi.SchemeGroupVersion.WithResource("volumeattributesclasses"),
 			vac,
+			vac,
+			vac.Namespace,
+			false,
+		},
+		{
+			"volumeattributesclasses VacFeatureGate disabled: finalizer already exists -> no new finalizer",
+			storageapi.SchemeGroupVersion.WithResource("volumeattributesclasses"),
+			vacWithFinalizer,
 			vacWithFinalizer,
 			vac.Namespace,
+			false,
 		},
 		{
-			"volumeattributesclasses: finalizer already exists -> no new finalizer",
+			"volumeattributesclasses VacFeatureGate enabled: create -> add finalizer",
+			storageapi.SchemeGroupVersion.WithResource("volumeattributesclasses"),
+			vac,
+			vacWithFinalizer,
+			vac.Namespace,
+			true,
+		},
+		{
+			"volumeattributesclasses VacFeatureGate enabled: finalizer already exists -> no new finalizer",
 			storageapi.SchemeGroupVersion.WithResource("volumeattributesclasses"),
 			vacWithFinalizer,
 			vacWithFinalizer,
 			vac.Namespace,
+			true,
 		},
 	}
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			ctrl := newPlugin()
 
-			// Enable feature gate for tests with VolumeAttributesClass
-			if test.object.GetObjectKind().GroupVersionKind().Kind == "VolumeAttributesClass" {
-				featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeAttributesClass, true)
-			}
+			featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeAttributesClass, test.enableVacFeatureGate)
 
 			obj := test.object.DeepCopyObject()
 			attrs := admission.NewAttributesRecord(