Skip to content

Commit a8a086f

Browse files
authored
Merge pull request kubernetes#128309 from mimowo/job-rollback-test-promotion
Rollback promotion of Job e2e test for pod failure policy using exit code
2 parents e526a27 + d521e44 commit a8a086f

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

test/conformance/testdata/conformance.yaml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,17 +1067,6 @@
10671067
codes.
10681068
release: v1.32
10691069
file: test/e2e/apps/job.go
1070-
- testname: Ensure pod failure policy allows to ignore failure matching on the exit
1071-
code
1072-
codename: '[sig-apps] Job should allow to use a pod failure policy to ignore failure
1073-
matching on exit code [Conformance]'
1074-
description: This test is using an indexed job. The pod corresponding to each index
1075-
creates a marker file on the host and runs 'forever' until evicted. Once the marker
1076-
file is created the pod succeeds seeing it on restart. Thus, we trigger one failure
1077-
per index due to eviction, so the Job would be marked as failed, if not for the
1078-
ignore rule matching on exit codes.
1079-
release: v1.32
1080-
file: test/e2e/apps/job.go
10811070
- testname: Verify Pod Failure policy allows to fail job early on exit code.
10821071
codename: '[sig-apps] Job should allow to use the pod failure policy on exit code
10831072
to fail the job early [Conformance]'

test/e2e/apps/job.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,15 +143,14 @@ var _ = SIGDescribe("Job", func() {
143143
})
144144

145145
/*
146-
Release: v1.32
147146
Testname: Ensure pod failure policy allows to ignore failure matching on the exit code
148147
Description: This test is using an indexed job. The pod corresponding to each index
149148
creates a marker file on the host and runs 'forever' until evicted. Once
150149
the marker file is created the pod succeeds seeing it on restart. Thus,
151150
we trigger one failure per index due to eviction, so the Job would be
152151
marked as failed, if not for the ignore rule matching on exit codes.
153152
*/
154-
framework.ConformanceIt("should allow to use a pod failure policy to ignore failure matching on exit code", func(ctx context.Context) {
153+
ginkgo.It("should allow to use a pod failure policy to ignore failure matching on exit code", func(ctx context.Context) {
155154
// We set the backoffLimit = numPods-1 so that we can tolerate random
156155
// failures (like OutOfPods from kubelet). Yet, the Job would fail if the
157156
// pod failures were not be ignored.

0 commit comments

Comments
 (0)