Skip to content

Commit ae1caa4

Browse files
authored
Merge pull request kubernetes#125961 from Jerry-yz/master
Chore: fix scheduler code comment typos
2 parents bfffd43 + bd90e99 commit ae1caa4

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

pkg/generated/openapi/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/scheduler/framework/interface.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ type QueueSortPlugin interface {
363363
// Failures from other extension points are regarded as temporal errors (e.g., network failure),
364364
// and the scheduler requeue Pods without this extension point - always requeue Pods to activeQ after backoff.
365365
// This is because such temporal errors cannot be resolved by specific cluster events,
366-
// and we have no choise but keep retrying scheduling until the failure is resolved.
366+
// and we have no choose but keep retrying scheduling until the failure is resolved.
367367
//
368368
// Plugins that make pod unschedulable (PreEnqueue, PreFilter, Filter, Reserve, and Permit plugins) should implement this interface,
369369
// otherwise the default implementation will be used, which is less efficient in requeueing Pods rejected by the plugin.

pkg/scheduler/internal/queue/scheduling_queue.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ type SchedulingQueue interface {
112112
Done(types.UID)
113113
Update(logger klog.Logger, oldPod, newPod *v1.Pod) error
114114
Delete(pod *v1.Pod) error
115-
// TODO(sanposhiho): move all PreEnqueueCkeck to Requeue and delete it from this parameter eventually.
115+
// TODO(sanposhiho): move all PreEnqueueCheck to Requeue and delete it from this parameter eventually.
116116
// Some PreEnqueueCheck include event filtering logic based on some in-tree plugins
117117
// and it affect badly to other plugins.
118118
// See https://github.com/kubernetes/kubernetes/issues/110175

staging/src/k8s.io/kube-scheduler/config/v1/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ type KubeSchedulerConfiguration struct {
6464
// Example: if the cluster size is 500 nodes and the value of this flag is 30,
6565
// then scheduler stops finding further feasible nodes once it finds 150 feasible ones.
6666
// When the value is 0, default percentage (5%--50% based on the size of the cluster) of the
67-
// nodes will be scored. It is overridden by profile level PercentageofNodesToScore.
67+
// nodes will be scored. It is overridden by profile level PercentageOfNodesToScore.
6868
PercentageOfNodesToScore *int32 `json:"percentageOfNodesToScore,omitempty"`
6969

7070
// PodInitialBackoffSeconds is the initial backoff for unschedulable pods.

0 commit comments

Comments
 (0)