Skip to content

Commit b1f2af0

Browse files
authored
Merge pull request kubernetes#128659 from saschagrunert/google-go-protobuf
Replace `github.com/golang/protobuf` with `google.golang.org/protobuf`
2 parents 77749c2 + c1d0e87 commit b1f2af0

File tree

8 files changed

+6
-14
lines changed

8 files changed

+6
-14
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ require (
3434
github.com/go-openapi/jsonreference v0.20.2
3535
github.com/godbus/dbus/v5 v5.1.0
3636
github.com/gogo/protobuf v1.3.2
37-
github.com/golang/protobuf v1.5.4
3837
github.com/google/cadvisor v0.51.0
3938
github.com/google/cel-go v0.22.0
4039
github.com/google/gnostic-models v0.6.8
@@ -157,6 +156,7 @@ require (
157156
github.com/go-openapi/swag v0.23.0 // indirect
158157
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
159158
github.com/golang-jwt/jwt/v4 v4.5.1 // indirect
159+
github.com/golang/protobuf v1.5.4 // indirect
160160
github.com/google/btree v1.0.1 // indirect
161161
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db // indirect
162162
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect

staging/src/k8s.io/api/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ require (
1717
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
1818
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
1919
github.com/go-logr/logr v1.4.2 // indirect
20-
github.com/golang/protobuf v1.5.4 // indirect
2120
github.com/google/go-cmp v0.6.0 // indirect
2221
github.com/google/gofuzz v1.2.0 // indirect
2322
github.com/json-iterator/go v1.1.12 // indirect
@@ -29,7 +28,6 @@ require (
2928
github.com/x448/float16 v0.8.4 // indirect
3029
golang.org/x/net v0.30.0 // indirect
3130
golang.org/x/text v0.21.0 // indirect
32-
google.golang.org/protobuf v1.35.1 // indirect
3331
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
3432
gopkg.in/inf.v0 v0.9.1 // indirect
3533
k8s.io/klog/v2 v2.130.1 // indirect

staging/src/k8s.io/api/go.sum

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apimachinery/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ require (
1313
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
1414
github.com/fxamacker/cbor/v2 v2.7.0
1515
github.com/gogo/protobuf v1.3.2
16-
github.com/golang/protobuf v1.5.4
1716
github.com/google/gnostic-models v0.6.8
1817
github.com/google/go-cmp v0.6.0
1918
github.com/google/gofuzz v1.2.0
@@ -41,6 +40,7 @@ require (
4140
github.com/go-openapi/jsonreference v0.20.2 // indirect
4241
github.com/go-openapi/swag v0.23.0 // indirect
4342
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
43+
github.com/golang/protobuf v1.5.4 // indirect
4444
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db // indirect
4545
github.com/josharian/intern v1.0.0 // indirect
4646
github.com/json-iterator/go v1.1.12 // indirect

staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip/roundtrip.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ import (
2424
"strings"
2525
"testing"
2626

27-
//nolint:staticcheck //iccheck // SA1019 Keep using deprecated module; it still seems to be maintained and the api of the recommended replacement differs
28-
"github.com/golang/protobuf/proto"
2927
"github.com/google/go-cmp/cmp"
3028
fuzz "github.com/google/gofuzz"
3129
flag "github.com/spf13/pflag"
@@ -431,7 +429,6 @@ func dataAsString(data []byte) string {
431429
dataString := string(data)
432430
if !strings.HasPrefix(dataString, "{") {
433431
dataString = "\n" + hex.Dump(data)
434-
proto.NewBuffer(make([]byte, 0, 1024)).DebugPrint("decoded object", data)
435432
}
436433
return dataString
437434
}

staging/src/k8s.io/client-go/discovery/discovery_client.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ import (
2929
"sync"
3030
"time"
3131

32-
//nolint:staticcheck // SA1019 Keep using module since it's still being maintained and the api of google.golang.org/protobuf/proto differs
33-
"github.com/golang/protobuf/proto"
3432
openapi_v2 "github.com/google/gnostic-models/openapiv2"
33+
"google.golang.org/protobuf/proto"
3534

3635
apidiscoveryv2 "k8s.io/api/apidiscovery/v2"
3736
apidiscoveryv2beta1 "k8s.io/api/apidiscovery/v2beta1"

staging/src/k8s.io/client-go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ godebug winsymlink=0
1010

1111
require (
1212
github.com/gogo/protobuf v1.3.2
13-
github.com/golang/protobuf v1.5.4
1413
github.com/google/gnostic-models v0.6.8
1514
github.com/google/go-cmp v0.6.0
1615
github.com/google/gofuzz v1.2.0
@@ -47,6 +46,7 @@ require (
4746
github.com/go-openapi/jsonreference v0.20.2 // indirect
4847
github.com/go-openapi/swag v0.23.0 // indirect
4948
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
49+
github.com/golang/protobuf v1.5.4 // indirect
5050
github.com/google/btree v1.0.1 // indirect
5151
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db // indirect
5252
github.com/josharian/intern v1.0.0 // indirect

test/e2e/storage/drivers/csi-test/mock/service/identity.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"context"
2121

2222
"github.com/container-storage-interface/spec/lib/go/csi"
23-
"github.com/golang/protobuf/ptypes/wrappers"
23+
"google.golang.org/protobuf/types/known/wrapperspb"
2424
)
2525

2626
func (s *service) GetPluginInfo(
@@ -41,7 +41,7 @@ func (s *service) Probe(
4141
*csi.ProbeResponse, error) {
4242

4343
return &csi.ProbeResponse{
44-
Ready: &wrappers.BoolValue{Value: true},
44+
Ready: &wrapperspb.BoolValue{Value: true},
4545
}, nil
4646
}
4747

0 commit comments

Comments
 (0)