Skip to content

Commit ba80f25

Browse files
committed
e2e_node: skip swap tests on cgroupv1
Signed-off-by: Peter Hunt <[email protected]>
1 parent c0f4879 commit ba80f25

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

test/e2e_node/swap_test.go

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,18 @@ package e2enode
1919
import (
2020
"context"
2121
"fmt"
22-
"k8s.io/kubernetes/pkg/apis/core/v1/helper/qos"
23-
"k8s.io/kubernetes/pkg/kubelet/apis/config"
24-
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
25-
"k8s.io/kubernetes/test/e2e/nodefeature"
26-
imageutils "k8s.io/kubernetes/test/utils/image"
2722
"math/big"
2823
"path/filepath"
2924
"strconv"
3025
"strings"
3126
"time"
3227

28+
"k8s.io/kubernetes/pkg/apis/core/v1/helper/qos"
29+
"k8s.io/kubernetes/pkg/kubelet/apis/config"
30+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
31+
"k8s.io/kubernetes/test/e2e/nodefeature"
32+
imageutils "k8s.io/kubernetes/test/utils/image"
33+
3334
"github.com/onsi/ginkgo/v2"
3435
"github.com/onsi/gomega"
3536
v1 "k8s.io/api/core/v1"
@@ -70,7 +71,9 @@ var _ = SIGDescribe("Swap", "[LinuxOnly]", nodefeature.Swap, func() {
7071
pod := getSwapTestPod(f, qosClass, memoryRequestEqualLimit)
7172
pod = runPodAndWaitUntilScheduled(f, pod)
7273

73-
gomega.Expect(isPodCgroupV2(f, pod)).To(gomega.BeTrueBecause("cgroup v2 is required for swap"))
74+
if !isPodCgroupV2(f, pod) {
75+
e2eskipper.Skipf("swap tests require cgroup v2")
76+
}
7477
gomega.Expect(getSwapBehavior()).To(gomega.Or(gomega.Equal(types.NoSwap), gomega.BeEmpty()), "NodeConformance is expected to run with NoSwap")
7578

7679
expectNoSwap(f, pod)
@@ -103,7 +106,9 @@ var _ = SIGDescribe("Swap", "[LinuxOnly]", nodefeature.Swap, func() {
103106
pod := getSwapTestPod(f, qosClass, memoryRequestEqualLimit)
104107
pod = runPodAndWaitUntilScheduled(f, pod)
105108

106-
gomega.Expect(isPodCgroupV2(f, pod)).To(gomega.BeTrueBecause("cgroup v2 is required for swap"))
109+
if !isPodCgroupV2(f, pod) {
110+
e2eskipper.Skipf("swap tests require cgroup v2")
111+
}
107112
gomega.Expect(getSwapBehavior()).To(gomega.Equal(types.LimitedSwap))
108113

109114
expectedSwapLimit := calcSwapForBurstablePod(f, pod)
@@ -136,7 +141,9 @@ var _ = SIGDescribe("Swap", "[LinuxOnly]", nodefeature.Swap, func() {
136141

137142
sleepingPod := getSleepingPod(f.Namespace.Name)
138143
sleepingPod = runPodAndWaitUntilScheduled(f, sleepingPod)
139-
gomega.Expect(isPodCgroupV2(f, sleepingPod)).To(gomega.BeTrueBecause("node uses cgroup v1"))
144+
if !isPodCgroupV2(f, sleepingPod) {
145+
e2eskipper.Skipf("swap tests require cgroup v2")
146+
}
140147

141148
nodeName = sleepingPod.Spec.NodeName
142149
gomega.Expect(nodeName).ToNot(gomega.BeEmpty(), "node name is empty")

0 commit comments

Comments
 (0)