Skip to content

Commit c0ed497

Browse files
committed
kubelet: remove deprecated otel NewNoopTracerProvider
Signed-off-by: TommyStarK <[email protected]>
1 parent 902a6b5 commit c0ed497

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

pkg/kubelet/images/image_gc_manager_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import (
2727
"github.com/stretchr/testify/require"
2828
"go.uber.org/mock/gomock"
2929

30-
oteltrace "go.opentelemetry.io/otel/trace"
30+
noopoteltrace "go.opentelemetry.io/otel/trace/noop"
3131
utilfeature "k8s.io/apiserver/pkg/util/feature"
3232
"k8s.io/client-go/tools/record"
3333
featuregatetesting "k8s.io/component-base/featuregate/testing"
@@ -51,7 +51,7 @@ func newRealImageGCManager(policy ImageGCPolicy, mockStatsProvider stats.Provide
5151
imageRecords: make(map[string]*imageRecord),
5252
statsProvider: mockStatsProvider,
5353
recorder: &record.FakeRecorder{},
54-
tracer: oteltrace.NewNoopTracerProvider().Tracer(""),
54+
tracer: noopoteltrace.NewTracerProvider().Tracer(""),
5555
}, fakeRuntime
5656
}
5757

@@ -949,7 +949,7 @@ func TestValidateImageGCPolicy(t *testing.T) {
949949
}
950950

951951
for _, tc := range testCases {
952-
if _, err := NewImageGCManager(nil, nil, nil, nil, tc.imageGCPolicy, oteltrace.NewNoopTracerProvider()); err != nil {
952+
if _, err := NewImageGCManager(nil, nil, nil, nil, tc.imageGCPolicy, noopoteltrace.NewTracerProvider()); err != nil {
953953
if err.Error() != tc.expectErr {
954954
t.Errorf("[%s:]Expected err:%v, but got:%v", tc.name, tc.expectErr, err.Error())
955955
}

pkg/kubelet/kubelet_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import (
3434
sdktrace "go.opentelemetry.io/otel/sdk/trace"
3535
"go.opentelemetry.io/otel/sdk/trace/tracetest"
3636
oteltrace "go.opentelemetry.io/otel/trace"
37+
noopoteltrace "go.opentelemetry.io/otel/trace/noop"
3738

3839
cadvisorapi "github.com/google/cadvisor/info/v1"
3940
cadvisorapiv2 "github.com/google/cadvisor/info/v2"
@@ -257,7 +258,7 @@ func newTestKubeletWithImageList(
257258
kubelet.cadvisor = &cadvisortest.Fake{}
258259
machineInfo, _ := kubelet.cadvisor.MachineInfo()
259260
kubelet.setCachedMachineInfo(machineInfo)
260-
kubelet.tracer = oteltrace.NewNoopTracerProvider().Tracer("")
261+
kubelet.tracer = noopoteltrace.NewTracerProvider().Tracer("")
261262

262263
fakeMirrorClient := podtest.NewFakeMirrorClient()
263264
secretManager := secret.NewSimpleSecretManager(kubelet.kubeClient)
@@ -312,7 +313,7 @@ func newTestKubeletWithImageList(
312313
HighThresholdPercent: 90,
313314
LowThresholdPercent: 80,
314315
}
315-
imageGCManager, err := images.NewImageGCManager(fakeRuntime, kubelet.StatsProvider, fakeRecorder, fakeNodeRef, fakeImageGCPolicy, oteltrace.NewNoopTracerProvider())
316+
imageGCManager, err := images.NewImageGCManager(fakeRuntime, kubelet.StatsProvider, fakeRecorder, fakeNodeRef, fakeImageGCPolicy, noopoteltrace.NewTracerProvider())
316317
assert.NoError(t, err)
317318
kubelet.imageManager = &fakeImageGCManager{
318319
fakeImageService: fakeRuntime,
@@ -3052,7 +3053,7 @@ func TestNewMainKubeletStandAlone(t *testing.T) {
30523053
MemoryThrottlingFactor: utilpointer.Float64(0),
30533054
}
30543055
var prober volume.DynamicPluginProber
3055-
tp := oteltrace.NewNoopTracerProvider()
3056+
tp := noopoteltrace.NewTracerProvider()
30563057
mockCtrl := gomock.NewController(t)
30573058
defer mockCtrl.Finish()
30583059
cadvisor := cadvisortest.NewMockInterface(mockCtrl)
@@ -3072,7 +3073,7 @@ func TestNewMainKubeletStandAlone(t *testing.T) {
30723073
fakeRuntime.Stop()
30733074
}()
30743075
fakeRecorder := &record.FakeRecorder{}
3075-
rtSvc := createRemoteRuntimeService(endpoint, t, oteltrace.NewNoopTracerProvider())
3076+
rtSvc := createRemoteRuntimeService(endpoint, t, noopoteltrace.NewTracerProvider())
30763077
kubeDep := &Dependencies{
30773078
Auth: nil,
30783079
CAdvisorInterface: cadvisor,

pkg/kubelet/kuberuntime/kuberuntime_manager_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
cadvisorapi "github.com/google/cadvisor/info/v1"
3232
"github.com/stretchr/testify/assert"
3333
"github.com/stretchr/testify/require"
34-
oteltrace "go.opentelemetry.io/otel/trace"
34+
noopoteltrace "go.opentelemetry.io/otel/trace/noop"
3535

3636
v1 "k8s.io/api/core/v1"
3737
"k8s.io/apimachinery/pkg/api/resource"
@@ -71,7 +71,7 @@ func customTestRuntimeManager(keyring *credentialprovider.BasicDockerKeyring) (*
7171
MemoryCapacity: uint64(memoryCapacityQuantity.Value()),
7272
}
7373
osInterface := &containertest.FakeOS{}
74-
manager, err := newFakeKubeRuntimeManager(fakeRuntimeService, fakeImageService, machineInfo, osInterface, &containertest.FakeRuntimeHelper{}, keyring, oteltrace.NewNoopTracerProvider().Tracer(""))
74+
manager, err := newFakeKubeRuntimeManager(fakeRuntimeService, fakeImageService, machineInfo, osInterface, &containertest.FakeRuntimeHelper{}, keyring, noopoteltrace.NewTracerProvider().Tracer(""))
7575
return fakeRuntimeService, fakeImageService, manager, err
7676
}
7777

0 commit comments

Comments
 (0)