Skip to content

Commit c48499d

Browse files
committed
fix ci
Signed-off-by: carlory <[email protected]>
1 parent 2382c01 commit c48499d

File tree

4 files changed

+3
-17
lines changed

4 files changed

+3
-17
lines changed

cluster/gce/gci/configure-kubeapiserver.sh

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ function configure-etcd-params {
5555
# in the manifest file, and then copies the manifest file to /etc/kubernetes/manifests.
5656
#
5757
# Assumed vars (which are calculated in function compute-master-manifest-variables)
58-
# CLOUD_CONFIG_OPT
59-
# CLOUD_CONFIG_VOLUME
60-
# CLOUD_CONFIG_MOUNT
6158
# DOCKER_REGISTRY
6259
# INSECURE_PORT_MAPPING
6360
function start-kube-apiserver {
@@ -66,9 +63,8 @@ function start-kube-apiserver {
6663
prepare-log-file "${KUBE_API_SERVER_AUDIT_LOG_PATH:-/var/log/kube-apiserver-audit.log}" "${KUBE_API_SERVER_RUNASUSER:-0}"
6764

6865
# Calculate variables and assemble the command line.
69-
local params="${API_SERVER_TEST_LOG_LEVEL:-"--v=2"} ${APISERVER_TEST_ARGS:-} ${CLOUD_CONFIG_OPT}"
66+
local params="${API_SERVER_TEST_LOG_LEVEL:-"--v=2"} ${APISERVER_TEST_ARGS:-}"
7067
params+=" --allow-privileged=true"
71-
params+=" --cloud-provider=${CLOUD_PROVIDER_FLAG:-external}"
7268
params+=" --client-ca-file=${CA_CERT_BUNDLE_PATH}"
7369

7470
# params is passed by reference, so no "$"
@@ -384,16 +380,12 @@ function start-kube-apiserver {
384380
sed -i -e "s@{{params}}@${params}@g" "${src_file}"
385381
sed -i -e "s@{{container_env}}@${container_env}@g" "${src_file}"
386382
sed -i -e "s@{{srv_sshproxy_path}}@/etc/srv/sshproxy@g" "${src_file}"
387-
sed -i -e "s@{{cloud_config_mount}}@${CLOUD_CONFIG_MOUNT}@g" "${src_file}"
388-
sed -i -e "s@{{cloud_config_volume}}@${CLOUD_CONFIG_VOLUME}@g" "${src_file}"
389383
sed -i -e "s@{{pillar\['kube_docker_registry'\]}}@${DOCKER_REGISTRY}@g" "${src_file}"
390384
sed -i -e "s@{{pillar\['kube-apiserver_docker_tag'\]}}@${kube_apiserver_docker_tag}@g" "${src_file}"
391385
sed -i -e "s@{{pillar\['allow_privileged'\]}}@true@g" "${src_file}"
392386
sed -i -e "s@{{liveness_probe_initial_delay}}@${KUBE_APISERVER_LIVENESS_PROBE_INITIAL_DELAY_SEC:-15}@g" "${src_file}"
393387
sed -i -e "s@{{secure_port}}@443@g" "${src_file}"
394388
sed -i -e "s@{{insecure_port_mapping}}@${INSECURE_PORT_MAPPING}@g" "${src_file}"
395-
sed -i -e "s@{{additional_cloud_config_mount}}@@g" "${src_file}"
396-
sed -i -e "s@{{additional_cloud_config_volume}}@@g" "${src_file}"
397389
sed -i -e "s@{{webhook_authn_config_mount}}@${webhook_authn_config_mount}@g" "${src_file}"
398390
sed -i -e "s@{{webhook_authn_config_volume}}@${webhook_authn_config_volume}@g" "${src_file}"
399391
sed -i -e "s@{{webhook_config_mount}}@${webhook_config_mount}@g" "${src_file}"

cluster/gce/manifests/kube-apiserver.manifest

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@
6767
"volumeMounts": [
6868
{{kms_socket_mount}}
6969
{{encryption_provider_mount}}
70-
{{cloud_config_mount}}
71-
{{additional_cloud_config_mount}}
7270
{{webhook_config_mount}}
7371
{{webhook_authn_config_mount}}
7472
{{csc_config_mount}}
@@ -108,8 +106,6 @@
108106
"volumes":[
109107
{{kms_socket_volume}}
110108
{{encryption_provider_volume}}
111-
{{cloud_config_volume}}
112-
{{additional_cloud_config_volume}}
113109
{{webhook_config_volume}}
114110
{{webhook_authn_config_volume}}
115111
{{csc_config_volume}}

test/e2e_node/kubelet_config_dir_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ shutdownGracePeriodByPodPriority:
8686
- priority: 3
8787
shutdownGracePeriodSeconds: 30
8888
featureGates:
89-
DisableKubeletCloudCredentialProviders: true
9089
PodAndContainerStatsFromCRI: true`)
9190
framework.ExpectNoError(os.WriteFile(filepath.Join(configDir, "10-kubelet.conf"), contents, 0755))
9291
contents = []byte(`apiVersion: kubelet.config.k8s.io/v1beta1
@@ -164,7 +163,7 @@ featureGates:
164163
},
165164
}
166165
// This covers the case where the fields within the map are overridden.
167-
overrides := map[string]bool{"DisableKubeletCloudCredentialProviders": true, "PodAndContainerStatsFromCRI": false, "DynamicResourceAllocation": true}
166+
overrides := map[string]bool{"PodAndContainerStatsFromCRI": false, "DynamicResourceAllocation": true}
168167
// In some CI jobs, `NodeSwap` is explicitly disabled as the images are cgroupv1 based,
169168
// so such flags should be picked up directly from the initial configuration
170169
if _, ok := initialConfig.FeatureGates["NodeSwap"]; ok {

test/e2e_node/remote/node_e2e.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,9 @@ func prependMemcgNotificationFlag(args string) string {
9797
// a credential provider plugin.
9898
func prependCredentialProviderFlag(args, workspace string) string {
9999
credentialProviderConfig := filepath.Join(workspace, "credential-provider.yaml")
100-
featureGateFlag := "--kubelet-flags=--feature-gates=DisableKubeletCloudCredentialProviders=true"
101100
configFlag := fmt.Sprintf("--kubelet-flags=--image-credential-provider-config=%s", credentialProviderConfig)
102101
binFlag := fmt.Sprintf("--kubelet-flags=--image-credential-provider-bin-dir=%s", workspace)
103-
return fmt.Sprintf("%s %s %s %s", featureGateFlag, configFlag, binFlag, args)
102+
return fmt.Sprintf("%s %s %s", configFlag, binFlag, args)
104103
}
105104

106105
// osSpecificActions takes OS specific actions required for the node tests

0 commit comments

Comments
 (0)