Skip to content

Commit c87ed89

Browse files
authored
Merge pull request kubernetes#131378 from cuishuang/master
fix: Fix non-constant format string in framework.Logf call
2 parents 359f36d + d10eb86 commit c87ed89

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/e2e/node/mount_propagation.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,11 @@ var _ = SIGDescribe("Mount propagation", func() {
197197
// Higher pids are more likely to be created after the first one
198198
kubeletPids := strings.Split(strings.TrimSuffix(kubeletPid, "\n"), " ")
199199
enterKubeletMountNS := fmt.Sprintf("nsenter -t %s -m", kubeletPids[len(kubeletPids)-1])
200-
framework.Logf(enterKubeletMountNS)
201200

202201
// Check that the master and host mounts are propagated to the container runtime's mount namespace
203202
for _, mountName := range []string{"host", master.Name} {
204203
cmd := fmt.Sprintf("%s cat \"%s/%s/file\"", enterKubeletMountNS, hostDir, mountName)
204+
framework.Logf("running command '%s' on node '%s'", cmd, node.Name)
205205
output, err := hostExec.IssueCommandWithResult(ctx, cmd, node)
206206
framework.ExpectNoError(err, "host container namespace should see mount from %s: %s", mountName, output)
207207
output = strings.TrimSuffix(output, "\n")
@@ -211,6 +211,7 @@ var _ = SIGDescribe("Mount propagation", func() {
211211
// Check that the slave, private, and default mounts are not propagated to the container runtime's mount namespace
212212
for _, podName := range []string{slave.Name, private.Name, defaultPropagation.Name} {
213213
cmd := fmt.Sprintf("%s test ! -e \"%s/%s/file\"", enterKubeletMountNS, hostDir, podName)
214+
framework.Logf("running command '%s' on node '%s'", cmd, node.Name)
214215
output, err := hostExec.IssueCommandWithResult(ctx, cmd, node)
215216
framework.ExpectNoError(err, "host container namespace shouldn't see mount from %s: %s", podName, output)
216217
}

0 commit comments

Comments
 (0)