Skip to content

Commit c9979e6

Browse files
committed
chore: Use generic sets for metrics
The sets.String has been deprecated.
1 parent b664351 commit c9979e6

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

staging/src/k8s.io/component-base/metrics/opts.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ func (o *SummaryOpts) toPromSummaryOpts() prometheus.SummaryOpts {
315315
}
316316

317317
type MetricLabelAllowList struct {
318-
labelToAllowList map[string]sets.String
318+
labelToAllowList map[string]sets.Set[string]
319319
}
320320

321321
func (allowList *MetricLabelAllowList) ConstrainToAllowedList(labelNameList, labelValueList []string) {
@@ -347,13 +347,13 @@ func SetLabelAllowListFromCLI(allowListMapping map[string]string) {
347347
for metricLabelName, labelValues := range allowListMapping {
348348
metricName := strings.Split(metricLabelName, ",")[0]
349349
labelName := strings.Split(metricLabelName, ",")[1]
350-
valueSet := sets.NewString(strings.Split(labelValues, ",")...)
350+
valueSet := sets.New[string](strings.Split(labelValues, ",")...)
351351

352352
allowList, ok := labelValueAllowLists[metricName]
353353
if ok {
354354
allowList.labelToAllowList[labelName] = valueSet
355355
} else {
356-
labelToAllowList := make(map[string]sets.String)
356+
labelToAllowList := make(map[string]sets.Set[string])
357357
labelToAllowList[labelName] = valueSet
358358
labelValueAllowLists[metricName] = &MetricLabelAllowList{
359359
labelToAllowList,

staging/src/k8s.io/component-base/metrics/opts_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ func TestDefaultStabilityLevel(t *testing.T) {
6565

6666
func TestConstrainToAllowedList(t *testing.T) {
6767
allowList := &MetricLabelAllowList{
68-
labelToAllowList: map[string]sets.String{
69-
"label_a": sets.NewString("allow_value1", "allow_value2"),
68+
labelToAllowList: map[string]sets.Set[string]{
69+
"label_a": sets.New[string]("allow_value1", "allow_value2"),
7070
},
7171
}
7272
labelNameList := []string{"label_a", "label_b"}
@@ -98,8 +98,8 @@ func TestConstrainToAllowedList(t *testing.T) {
9898

9999
func TestConstrainLabelMap(t *testing.T) {
100100
allowList := &MetricLabelAllowList{
101-
labelToAllowList: map[string]sets.String{
102-
"label_a": sets.NewString("allow_value1", "allow_value2"),
101+
labelToAllowList: map[string]sets.Set[string]{
102+
"label_a": sets.New[string]("allow_value1", "allow_value2"),
103103
},
104104
}
105105
var tests = []struct {
@@ -154,13 +154,13 @@ func TestSetLabelAllowListFromManifest(t *testing.T) {
154154
metric2,label2: v3`,
155155
expectlabelValueAllowLists: map[string]*MetricLabelAllowList{
156156
"metric1": {
157-
labelToAllowList: map[string]sets.String{
158-
"label1": sets.NewString("v1", "v2"),
157+
labelToAllowList: map[string]sets.Set[string]{
158+
"label1": sets.New[string]("v1", "v2"),
159159
},
160160
},
161161
"metric2": {
162-
labelToAllowList: map[string]sets.String{
163-
"label2": sets.NewString("v3"),
162+
labelToAllowList: map[string]sets.Set[string]{
163+
"label2": sets.New[string]("v3"),
164164
},
165165
},
166166
},

0 commit comments

Comments
 (0)