Skip to content

Commit cd69335

Browse files
Jefftreesttts
authored andcommitted
informers: add comment that Start does not block
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
1 parent c7a1fa4 commit cd69335

File tree

12 files changed

+12
-1
lines changed
  • staging/src/k8s.io
    • apiextensions-apiserver
      • examples/client-go/pkg/client/informers/externalversions
      • pkg/client/informers/externalversions
    • client-go/informers
    • code-generator
    • kube-aggregator/pkg/client/informers/externalversions
    • sample-apiserver/pkg/generated/informers/externalversions
    • sample-controller/pkg/generated/informers/externalversions

12 files changed

+12
-1
lines changed

staging/src/k8s.io/apiextensions-apiserver/examples/client-go/pkg/client/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apiextensions-apiserver/pkg/client/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/client-go/informers/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/code-generator/cmd/informer-gen/generators/factory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ type SharedInformerFactory interface {
300300
// Start initializes all requested informers. They are handled in goroutines
301301
// which run until the stop channel gets closed.
302302
// Warning: Start does not block. When run in a go-routine, it will race with a later WaitForCacheSync.
303-
Start(stopCh <-chan struct{})
303+
Start(stopCh <-chan struct{})
304304
305305
// Shutdown marks a factory as shutting down. At that point no new
306306
// informers can be started anymore and Start will return without

staging/src/k8s.io/code-generator/examples/HyphenGroup/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/code-generator/examples/MixedCase/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/code-generator/examples/apiserver/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/code-generator/examples/crd/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/code-generator/examples/single/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/kube-aggregator/pkg/client/informers/externalversions/factory.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)