Skip to content

Commit d36b267

Browse files
authored
Merge pull request kubernetes#124660 from danwinship/feature-loadbalancer
Fix LoadBalancer tests to be provider-agnostic
2 parents eeb42fa + 67e0c51 commit d36b267

File tree

3 files changed

+1871
-6
lines changed

3 files changed

+1871
-6
lines changed

test/e2e/feature/feature.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,6 @@ var (
147147
// Ingress.networking.k8s.io to be present.
148148
Ingress = framework.WithFeature(framework.ValidFeatures.Add("Ingress"))
149149

150-
// TODO: document the feature (owning SIG, when to use this feature for a test)
151-
IngressScale = framework.WithFeature(framework.ValidFeatures.Add("IngressScale"))
152-
153150
// TODO: document the feature (owning SIG, when to use this feature for a test)
154151
InPlacePodVerticalScaling = framework.WithFeature(framework.ValidFeatures.Add("InPlacePodVerticalScaling"))
155152

@@ -178,6 +175,10 @@ var (
178175
// TODO: document the feature (owning SIG, when to use this feature for a test)
179176
LabelSelector = framework.WithFeature(framework.ValidFeatures.Add("LabelSelector"))
180177

178+
// Owner: sig-network
179+
// Marks tests that require a cloud provider that implements LoadBalancer Services
180+
LoadBalancer = framework.WithFeature(framework.ValidFeatures.Add("LoadBalancer"))
181+
181182
// TODO: document the feature (owning SIG, when to use this feature for a test)
182183
LocalStorageCapacityIsolation = framework.WithFeature(framework.ValidFeatures.Add("LocalStorageCapacityIsolation"))
183184

@@ -190,9 +191,6 @@ var (
190191
// TODO: document the feature (owning SIG, when to use this feature for a test)
191192
MemoryManager = framework.WithFeature(framework.ValidFeatures.Add("MemoryManager"))
192193

193-
// TODO: document the feature (owning SIG, when to use this feature for a test)
194-
NEG = framework.WithFeature(framework.ValidFeatures.Add("NEG"))
195-
196194
// Owner: sig-network
197195
// Marks tests that require working external DNS.
198196
NetworkingDNS = framework.WithFeature(framework.ValidFeatures.Add("Networking-DNS"))

0 commit comments

Comments
 (0)