Skip to content

Commit d44ac38

Browse files
committed
Promote e2e to conformance tests for JobBackoffLimitPerIndex
1 parent a91ed90 commit d44ac38

File tree

2 files changed

+37
-6
lines changed

2 files changed

+37
-6
lines changed

test/conformance/testdata/conformance.yaml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,6 +1109,17 @@
11091109
and delete the job. Job MUST be deleted successfully.
11101110
release: v1.15
11111111
file: test/e2e/apps/job.go
1112+
- testname: Ensure that all indexes are executed for an indexed job with backoffLimitPerIndex
1113+
despite some failing
1114+
codename: '[sig-apps] Job should execute all indexes despite some failing when using
1115+
backoffLimitPerIndex [Conformance]'
1116+
description: Create an indexed job and ensure that all indexes are either failed
1117+
or succeeded, depending on the end state of the corresponding pods. Pods with
1118+
odd indexes fail, while the pods with even indexes succeeded. Also, verify that
1119+
the number of failed pods doubles the number of failing indexes, as the backoffLimitPerIndex=1,
1120+
allowing for one pod recreation before marking that indexed failed.
1121+
release: v1.33
1122+
file: test/e2e/apps/job.go
11121123
- testname: Jobs, manage lifecycle
11131124
codename: '[sig-apps] Job should manage the lifecycle of a job [Conformance]'
11141125
description: Attempt to create a suspended Job which MUST succeed. Attempt to patch
@@ -1119,13 +1130,30 @@
11191130
via a label selector.
11201131
release: v1.25
11211132
file: test/e2e/apps/job.go
1133+
- testname: Mark indexes as failed when the FailIndex action is matched in podFailurePolicy
1134+
codename: '[sig-apps] Job should mark indexes as failed when the FailIndex action
1135+
is matched in podFailurePolicy [Conformance]'
1136+
description: Create an indexed job with backoffLimitPerIndex, and podFailurePolicy
1137+
with the FailIndex action. Verify the failed pods matching the pod failure policy
1138+
result in marking the corresponding indexes as failed without restarts, despite
1139+
backoffLimitPerIndex > 0.
1140+
release: v1.33
1141+
file: test/e2e/apps/job.go
11221142
- testname: Jobs, completion after task failure
11231143
codename: '[sig-apps] Job should run a job to completion when tasks sometimes fail
11241144
and are locally restarted [Conformance]'
11251145
description: Explicitly cause the tasks to fail once initially. After restarting,
11261146
the Job MUST execute to completion.
11271147
release: v1.16
11281148
file: test/e2e/apps/job.go
1149+
- testname: Terminate job execution when the maxFailedIndexes is exceeded
1150+
codename: '[sig-apps] Job should terminate job execution when the number of failed
1151+
indexes exceeds maxFailedIndexes [Conformance]'
1152+
description: Create an indexed job with backoffLimitPerIndex and maxFailedIndexes.
1153+
Verify the job execution is terminated as soon as the number of failed indexes
1154+
exceeds maxFailedIndexes.
1155+
release: v1.33
1156+
file: test/e2e/apps/job.go
11291157
- testname: ReplicaSet, is created, Replaced and Patched
11301158
codename: '[sig-apps] ReplicaSet Replace and Patch tests [Conformance]'
11311159
description: Create a ReplicaSet (RS) with a single Pod. The Pod MUST be verified

test/e2e/apps/job.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -593,13 +593,14 @@ done`}
593593
})
594594

595595
/*
596-
Testcase: Ensure that all indexes are executed for an indexed job with backoffLimitPerIndex despite some failing
596+
Release: v1.33
597+
Testname: Ensure that all indexes are executed for an indexed job with backoffLimitPerIndex despite some failing
597598
Description: Create an indexed job and ensure that all indexes are either failed or succeeded, depending
598599
on the end state of the corresponding pods. Pods with odd indexes fail, while the pods with even indexes
599600
succeeded. Also, verify that the number of failed pods doubles the number of failing indexes, as the
600601
backoffLimitPerIndex=1, allowing for one pod recreation before marking that indexed failed.
601602
*/
602-
ginkgo.It("should execute all indexes despite some failing when using backoffLimitPerIndex", func(ctx context.Context) {
603+
framework.ConformanceIt("should execute all indexes despite some failing when using backoffLimitPerIndex", func(ctx context.Context) {
603604
parallelism := int32(2)
604605
completions := int32(4)
605606
backoffLimit := int32(6) // default value
@@ -627,12 +628,13 @@ done`}
627628
})
628629

629630
/*
630-
Testcase: Terminate job execution when the maxFailedIndexes is exceeded
631+
Release: v1.33
632+
Testname: Terminate job execution when the maxFailedIndexes is exceeded
631633
Description: Create an indexed job with backoffLimitPerIndex and maxFailedIndexes.
632634
Verify the job execution is terminated as soon as the number of failed
633635
indexes exceeds maxFailedIndexes.
634636
*/
635-
ginkgo.It("should terminate job execution when the number of failed indexes exceeds maxFailedIndexes", func(ctx context.Context) {
637+
framework.ConformanceIt("should terminate job execution when the number of failed indexes exceeds maxFailedIndexes", func(ctx context.Context) {
636638
// we use parallelism=1 to make sure in the asserts only one pod was created
637639
parallelism := int32(1)
638640
completions := int32(4)
@@ -712,13 +714,14 @@ done`}
712714
})
713715

714716
/*
715-
Testcase: Mark indexes as failed when the FailIndex action is matched in podFailurePolicy
717+
Release: v1.33
718+
Testname: Mark indexes as failed when the FailIndex action is matched in podFailurePolicy
716719
Description: Create an indexed job with backoffLimitPerIndex, and podFailurePolicy
717720
with the FailIndex action. Verify the failed pods matching the pod failure policy
718721
result in marking the corresponding indexes as failed without restarts, despite
719722
backoffLimitPerIndex > 0.
720723
*/
721-
ginkgo.It("should mark indexes as failed when the FailIndex action is matched in podFailurePolicy", func(ctx context.Context) {
724+
framework.ConformanceIt("should mark indexes as failed when the FailIndex action is matched in podFailurePolicy", func(ctx context.Context) {
722725
parallelism := int32(2)
723726
completions := int32(2)
724727
backoffLimit := int32(6) // default value

0 commit comments

Comments
 (0)