Skip to content

Commit d663306

Browse files
committed
Remove the not-even alpha feature setting
Remove the setting for the feature gate that are not even alpha because Compatibility Versions (KEP-4330) don't allow it.
1 parent bc74476 commit d663306

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

cmd/kube-scheduler/app/server_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,8 @@ import (
3939
basecompatibility "k8s.io/component-base/compatibility"
4040
componentbaseconfig "k8s.io/component-base/config"
4141
"k8s.io/component-base/featuregate"
42-
featuregatetesting "k8s.io/component-base/featuregate/testing"
4342
configv1 "k8s.io/kube-scheduler/config/v1"
4443
"k8s.io/kubernetes/cmd/kube-scheduler/app/options"
45-
"k8s.io/kubernetes/pkg/features"
4644
"k8s.io/kubernetes/pkg/scheduler/apis/config"
4745
"k8s.io/kubernetes/pkg/scheduler/apis/config/testing/defaults"
4846
"k8s.io/kubernetes/pkg/scheduler/framework"
@@ -222,19 +220,6 @@ leaderElection:
222220
wantErr bool
223221
wantFeaturesGates map[string]bool
224222
}{
225-
{
226-
name: "default config with an alpha feature enabled",
227-
flags: []string{
228-
"--kubeconfig", configKubeconfig,
229-
"--feature-gates=StorageCapacityScoring=true",
230-
},
231-
wantPlugins: map[string]*config.Plugins{
232-
"default-scheduler": defaults.ExpandedPluginsV1,
233-
},
234-
restoreFeatures: map[featuregate.Feature]bool{
235-
features.StorageCapacityScoring: false,
236-
},
237-
},
238223
{
239224
name: "component configuration v1 with only scheduler name configured",
240225
flags: []string{
@@ -435,9 +420,6 @@ leaderElection:
435420

436421
for _, tc := range testcases {
437422
t.Run(tc.name, func(t *testing.T) {
438-
for k, v := range tc.restoreFeatures {
439-
featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, k, v)
440-
}
441423
componentGlobalsRegistry := basecompatibility.NewComponentGlobalsRegistry()
442424
verKube := basecompatibility.NewEffectiveVersionFromString("1.32", "1.31", "1.31")
443425
fg := feature.DefaultFeatureGate.DeepCopy()

0 commit comments

Comments
 (0)