forked from kubernetes/kubernetes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit d66ced5
committed
client-go/tools/cache: fix TestAddWhileActive
4638ba9 added tracking of the goroutine which
executes informer.Run. In the TestAddWhileActive the original `go
informer.Run()` was left in place, causing a data race between the two
`informer.Run` instances:
==================
WARNING: DATA RACE
Read at 0x00c000262398 by goroutine 5302:
k8s.io/client-go/tools/cache.(*controller).RunWithContext()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/controller.go:162 +0x1ad
k8s.io/client-go/tools/cache.(*sharedIndexInformer).RunWithContext()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:584 +0x6c5
k8s.io/client-go/tools/cache.(*sharedIndexInformer).Run()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:527 +0x48
k8s.io/client-go/tools/cache.TestAddWhileActive.gowrap1()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go:1080 +0x17
Previous write at 0x00c000262398 by goroutine 5301:
k8s.io/client-go/tools/cache.New()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/controller.go:142 +0x9de
k8s.io/client-go/tools/cache.(*sharedIndexInformer).RunWithContext.func1()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:562 +0xa78
k8s.io/client-go/tools/cache.(*sharedIndexInformer).RunWithContext()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:565 +0x119
k8s.io/client-go/tools/cache.(*sharedIndexInformer).Run()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:527 +0x44
k8s.io/client-go/tools/cache.(*sharedIndexInformer).Run-fm()
<autogenerated>:1 +0x17
k8s.io/client-go/tools/cache.TestAddWhileActive.(*Group).StartWithChannel.func2()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:55 +0x38
k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:72 +0x86
Goroutine 5302 (running) created at:
k8s.io/client-go/tools/cache.TestAddWhileActive()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go:1080 +0x93e
testing.tRunner()
/usr/local/go/src/testing/testing.go:1690 +0x226
testing.(*T).Run.gowrap1()
/usr/local/go/src/testing/testing.go:1743 +0x44
Goroutine 5301 (running) created at:
k8s.io/apimachinery/pkg/util/wait.(*Group).Start()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:70 +0xe4
k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:54 +0x7e6
k8s.io/client-go/tools/cache.TestAddWhileActive()
/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go:1074 +0x6a1
testing.tRunner()
/usr/local/go/src/testing/testing.go:1690 +0x226
testing.(*T).Run.gowrap1()
/usr/local/go/src/testing/testing.go:1743 +0x44
==================1 parent f3cbd79 commit d66ced5Copy full SHA for d66ced5
File tree
Expand file treeCollapse file tree
1 file changed
+0
-1
lines changedFilter options
- staging/src/k8s.io/client-go/tools/cache
Expand file treeCollapse file tree
1 file changed
+0
-1
lines changedCollapse file: staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go
staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go
Copy file name to clipboardExpand all lines: staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go-1Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1077 | 1077 |
| |
1078 | 1078 |
| |
1079 | 1079 |
| |
1080 |
| - | |
1081 | 1080 |
| |
1082 | 1081 |
| |
1083 | 1082 |
| |
|
0 commit comments