Skip to content

Commit d92c70b

Browse files
committed
enable go-required check
Signed-off-by: xin.li <[email protected]>
1 parent bc4ae15 commit d92c70b

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

hack/golangci.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,5 +277,4 @@ linters-settings: # please keep this alphabetized
277277
enable-all: true
278278
disable: # TODO: remove each disabled rule and fix it
279279
- float-compare
280-
- go-require
281280
- require-error

hack/golangci.yaml.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,6 @@ linters-settings: # please keep this alphabetized
242242
disable: # TODO: remove each disabled rule and fix it
243243
{{- if .Base }}
244244
- float-compare
245-
- go-require
246245
{{- end}}
247246
- require-error
248247
{{- end}}

staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/internal/generic/controller_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ func TestInformerNeverStarts(t *testing.T) {
291291
go func() {
292292
defer wg.Done()
293293
stopReason := myController.Run(testContext)
294-
if !errors.Is(stopReason, context.Canceled) {
294+
if !errors.Is(stopReason, context.DeadlineExceeded) {
295295
t.Errorf("expected error to be context.Canceled, but got: %v", stopReason)
296296
}
297297
}()

0 commit comments

Comments
 (0)