Skip to content

Commit ded7ad5

Browse files
authored
Merge pull request kubernetes#125513 from mauri870/hotfix/grpc-handle-err
kubelet/cm/devicemanager: log grpc Serve error
2 parents b1b4e5d + 694d813 commit ded7ad5

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pkg/kubelet/cm/devicemanager/plugin/v1beta1/server.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,9 @@ func (s *server) Start() error {
109109
api.RegisterRegistrationServer(s.grpc, s)
110110
go func() {
111111
defer s.wg.Done()
112-
s.grpc.Serve(ln)
112+
if err = s.grpc.Serve(ln); err != nil {
113+
klog.ErrorS(err, "Error while serving device plugin registration grpc server")
114+
}
113115
}()
114116

115117
return nil

pkg/kubelet/cm/devicemanager/plugin/v1beta1/stub.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ func (m *Stub) Start() error {
156156

157157
go func() {
158158
defer m.wg.Done()
159-
m.server.Serve(sock)
159+
if err = m.server.Serve(sock); err != nil {
160+
klog.ErrorS(err, "Error while serving device plugin registration grpc server")
161+
}
160162
}()
161163

162164
var lastDialErr error

0 commit comments

Comments
 (0)