Skip to content

Commit def9520

Browse files
committed
node: topology-mgr: Add metadata to logs
Ensure that if possible, we provide sufficient metadata in logs. Signed-off-by: Swati Sehgal <[email protected]>
1 parent 9a9f10b commit def9520

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

pkg/kubelet/cm/topologymanager/fake_topology_manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func NewFakeManagerWithHint(hint *TopologyHint) Manager {
4545

4646
// NewFakeManagerWithPolicy returns an instance of fake topology manager with specified policy
4747
func NewFakeManagerWithPolicy(policy Policy) Manager {
48-
klog.InfoS("NewFakeManagerWithPolicy")
48+
klog.InfoS("NewFakeManagerWithPolicy", "policy", policy.Name())
4949
return &fakeManager{
5050
policy: policy,
5151
}

pkg/kubelet/cm/topologymanager/scope_container.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package topologymanager
1818

1919
import (
20-
"k8s.io/api/core/v1"
20+
"k8s.io/api/core/v1"
2121
"k8s.io/klog/v2"
2222
"k8s.io/kubernetes/pkg/kubelet/cm/admission"
2323
"k8s.io/kubernetes/pkg/kubelet/cm/containermap"
@@ -84,6 +84,6 @@ func (s *containerScope) accumulateProvidersHints(pod *v1.Pod, container *v1.Con
8484
func (s *containerScope) calculateAffinity(pod *v1.Pod, container *v1.Container) (TopologyHint, bool) {
8585
providersHints := s.accumulateProvidersHints(pod, container)
8686
bestHint, admit := s.policy.Merge(providersHints)
87-
klog.InfoS("ContainerTopologyHint", "bestHint", bestHint)
87+
klog.InfoS("ContainerTopologyHint", "bestHint", bestHint, "pod", klog.KObj(pod), "containerName", container.Name)
8888
return bestHint, admit
8989
}

pkg/kubelet/cm/topologymanager/scope_pod.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,6 @@ func (s *podScope) accumulateProvidersHints(pod *v1.Pod) []map[string][]Topology
8484
func (s *podScope) calculateAffinity(pod *v1.Pod) (TopologyHint, bool) {
8585
providersHints := s.accumulateProvidersHints(pod)
8686
bestHint, admit := s.policy.Merge(providersHints)
87-
klog.InfoS("PodTopologyHint", "bestHint", bestHint)
87+
klog.InfoS("PodTopologyHint", "bestHint", bestHint, "pod", klog.KObj(pod))
8888
return bestHint, admit
8989
}

0 commit comments

Comments
 (0)