Skip to content

Commit df1e9ee

Browse files
committed
skipping InPlacePodVerticleScaling unit tests on Windows
Signed-off-by: Mark Rossetti <[email protected]>
1 parent fbdf890 commit df1e9ee

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

pkg/kubelet/kubelet_pods_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"os"
2525
"path/filepath"
2626
"reflect"
27+
goruntime "runtime"
2728
"sort"
2829
"strings"
2930
"testing"
@@ -3821,6 +3822,9 @@ func Test_generateAPIPodStatus(t *testing.T) {
38213822
}
38223823

38233824
func Test_generateAPIPodStatusForInPlaceVPAEnabled(t *testing.T) {
3825+
if goruntime.GOOS == "windows" {
3826+
t.Skip("InPlacePodVerticalScaling is not currently supported for Windows")
3827+
}
38243828
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true)
38253829
testContainerName := "ctr0"
38263830
testContainerID := kubecontainer.ContainerID{Type: "test", ID: testContainerName}
@@ -4635,6 +4639,9 @@ func TestConvertToAPIContainerStatusesDataRace(t *testing.T) {
46354639
}
46364640

46374641
func TestConvertToAPIContainerStatusesForResources(t *testing.T) {
4642+
if goruntime.GOOS == "windows" {
4643+
t.Skip("InPlacePodVerticalScaling is not currently supported for Windows")
4644+
}
46384645
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true)
46394646

46404647
nowTime := time.Now()

pkg/kubelet/kubelet_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2583,6 +2583,9 @@ func TestPodResourceAllocationReset(t *testing.T) {
25832583
}
25842584

25852585
func TestHandlePodResourcesResize(t *testing.T) {
2586+
if goruntime.GOOS == "windows" {
2587+
t.Skip("InPlacePodVerticalScaling is not currently supported for Windows")
2588+
}
25862589
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true)
25872590
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.SidecarContainers, true)
25882591
testKubelet := newTestKubelet(t, false)

0 commit comments

Comments
 (0)