Skip to content

Commit e0e6c96

Browse files
authored
Merge pull request kubernetes#125112 from neolit123/1.31-add-v-to-windows-pause-after-promo
dependencies: start using registry.k8s.io/pause:3.10
2 parents 3332eef + 5e290eb commit e0e6c96

File tree

59 files changed

+85
-95
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+85
-95
lines changed

build/dependencies.yaml

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -189,17 +189,14 @@ dependencies:
189189
- path: build/common.sh
190190
match: __default_go_runner_version=
191191

192-
# TODO: enable once pause 3.10 is promoted
193-
# https://github.com/kubernetes/kubernetes/issues/125092
194-
#
195-
# - name: "registry.k8s.io/pause"
196-
# version: 3.10
197-
# refPaths:
198-
# - path: build/pause/Makefile
199-
# match: TAG\s*\?=
192+
- name: "registry.k8s.io/pause"
193+
version: 3.10
194+
refPaths:
195+
- path: build/pause/Makefile
196+
match: TAG\s*\?=
200197

201198
- name: "registry.k8s.io/pause: dependents"
202-
version: 3.9
199+
version: 3.10
203200
refPaths:
204201
- path: cluster/gce/config-common.sh
205202
match: registry.k8s.io\/pause:\d+\.\d+
@@ -209,12 +206,6 @@ dependencies:
209206
match: registry.k8s.io\/pause:\d+\.\d+
210207
- path: cmd/kubeadm/app/constants/constants.go
211208
match: PauseVersion\s+=
212-
- path: cmd/kubeadm/app/util/template_test.go
213-
match: validTmpl\s+=
214-
- path: cmd/kubeadm/app/util/template_test.go
215-
match: validTmplOut\s+=
216-
- path: cmd/kubeadm/app/util/template_test.go
217-
match: doNothing\s+=
218209
- path: cmd/kubelet/app/options/container_runtime.go
219210
match: defaultPodSandboxImageVersion\s+=
220211
- path: hack/testdata/pod-with-precision.json
@@ -249,8 +240,6 @@ dependencies:
249240
match: registry.k8s.io\/pause:\d+\.\d+
250241
- path: test/integration/scheduler_perf/config/pod-with-topology-spreading.yaml
251242
match: registry.k8s.io\/pause:\d+\.\d+
252-
- path: test/utils/runners.go
253-
match: registry.k8s.io\/pause:\d+\.\d+
254243
- path: test/utils/image/manifest.go
255244
match: configs\[Pause\] = Config{list\.GcRegistry, "pause", "\d+\.\d+(.\d+)?"}
256245

cluster/gce/config-common.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export WINDOWS_KUBEPROXY_KUBECONFIG_FILE="${WINDOWS_K8S_DIR}\kubeproxy.kubeconfi
154154
# Path for kube-proxy kubeconfig file on Windows nodes.
155155
export WINDOWS_NODEPROBLEMDETECTOR_KUBECONFIG_FILE="${WINDOWS_K8S_DIR}\node-problem-detector.kubeconfig"
156156
# Pause container image for Windows container.
157-
export WINDOWS_INFRA_CONTAINER="registry.k8s.io/pause:3.9"
157+
export WINDOWS_INFRA_CONTAINER="registry.k8s.io/pause:3.10"
158158
# Storage Path for csi-proxy. csi-proxy only needs to be installed for Windows.
159159
export CSI_PROXY_STORAGE_PATH="https://storage.googleapis.com/gke-release/csi-proxy"
160160
# Version for csi-proxy

cluster/gce/gci/configure-helper.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3279,7 +3279,7 @@ oom_score = -999
32793279
[plugins."io.containerd.grpc.v1.cri"]
32803280
stream_server_address = "127.0.0.1"
32813281
max_container_log_line_size = ${CONTAINERD_MAX_CONTAINER_LOG_LINE:-262144}
3282-
sandbox_image = "${CONTAINERD_INFRA_CONTAINER:-"registry.k8s.io/pause:3.9"}"
3282+
sandbox_image = "${CONTAINERD_INFRA_CONTAINER:-"registry.k8s.io/pause:3.10"}"
32833283
[plugins."io.containerd.grpc.v1.cri".cni]
32843284
bin_dir = "${KUBE_HOME}/bin"
32853285
conf_dir = "/etc/cni/net.d"

cluster/gce/windows/smoke-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ spec:
341341
spec:
342342
containers:
343343
- name: pause-win
344-
image: registry.k8s.io/pause:3.9
344+
image: registry.k8s.io/pause:3.10
345345
nodeSelector:
346346
kubernetes.io/os: windows
347347
tolerations:

cmd/kubeadm/app/constants/constants.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ const (
435435
ModeNode string = "Node"
436436

437437
// PauseVersion indicates the default pause image version for kubeadm
438-
PauseVersion = "3.9"
438+
PauseVersion = "3.10"
439439

440440
// CgroupDriverSystemd holds the systemd driver type
441441
CgroupDriverSystemd = "systemd"

cmd/kubeadm/app/phases/kubelet/flags_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ func TestBuildKubeletArgs(t *testing.T) {
7979
nodeRegOpts: &kubeadmapi.NodeRegistrationOptions{
8080
CRISocket: "unix:///var/run/containerd/containerd.sock",
8181
},
82-
pauseImage: "registry.k8s.io/pause:3.9",
82+
pauseImage: "registry.k8s.io/pause:ver",
8383
},
8484
expected: []kubeadmapi.Arg{
8585
{Name: "container-runtime-endpoint", Value: "unix:///var/run/containerd/containerd.sock"},
86-
{Name: "pod-infra-container-image", Value: "registry.k8s.io/pause:3.9"},
86+
{Name: "pod-infra-container-image", Value: "registry.k8s.io/pause:ver"},
8787
},
8888
},
8989
}

cmd/kubeadm/app/util/runtime/runtime_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ func TestListKubeContainers(t *testing.T) {
164164
func TestSandboxImage(t *testing.T) {
165165
fcmd := fakeexec.FakeCmd{
166166
CombinedOutputScript: []fakeexec.FakeAction{
167-
func() ([]byte, []byte, error) { return []byte("registry.k8s.io/pause:3.9"), nil, nil },
168-
func() ([]byte, []byte, error) { return []byte("registry.k8s.io/pause:3.9\n"), nil, nil },
167+
func() ([]byte, []byte, error) { return []byte("registry.k8s.io/pause:ver"), nil, nil },
168+
func() ([]byte, []byte, error) { return []byte("registry.k8s.io/pause:ver\n"), nil, nil },
169169
func() ([]byte, []byte, error) { return nil, nil, nil },
170170
func() ([]byte, []byte, error) { return nil, nil, &fakeexec.FakeExitError{Status: 1} },
171171
},
@@ -181,8 +181,8 @@ func TestSandboxImage(t *testing.T) {
181181
expected string
182182
isError bool
183183
}{
184-
{"valid: read sandbox image normally", "registry.k8s.io/pause:3.9", false},
185-
{"valid: read sandbox image with leading/trailing white spaces", "registry.k8s.io/pause:3.9", false},
184+
{"valid: read sandbox image normally", "registry.k8s.io/pause:ver", false},
185+
{"valid: read sandbox image with leading/trailing white spaces", "registry.k8s.io/pause:ver", false},
186186
{"invalid: read empty sandbox image", "", true},
187187
{"invalid: failed to read sandbox image", "", true},
188188
}

cmd/kubeadm/app/util/template_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ import (
2121
)
2222

2323
const (
24-
validTmpl = "image: {{ .ImageRepository }}/pause:3.9"
25-
validTmplOut = "image: registry.k8s.io/pause:3.9"
26-
doNothing = "image: registry.k8s.io/pause:3.9"
24+
validTmpl = "image: {{ .ImageRepository }}/pause:ver"
25+
validTmplOut = "image: registry.k8s.io/pause:ver"
26+
doNothing = "image: registry.k8s.io/pause:ver"
2727
invalidTmpl1 = "{{ .baz }/d}"
2828
invalidTmpl2 = "{{ !foobar }}"
2929
)

cmd/kubelet/app/options/container_runtime.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
const (
2424
// When these values are updated, also update test/utils/image/manifest.go
2525
defaultPodSandboxImageName = "registry.k8s.io/pause"
26-
defaultPodSandboxImageVersion = "3.9"
26+
defaultPodSandboxImageVersion = "3.10"
2727
)
2828

2929
var (

hack/testdata/filter/pod-apply-selector.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ metadata:
88
spec:
99
containers:
1010
- name: kubernetes-pause
11-
image: registry.k8s.io/pause:3.9
11+
image: registry.k8s.io/pause:3.10

0 commit comments

Comments
 (0)