Merge pull request kubernetes#124143 from enj/enj/i/svm_update_crd_flake

k8s-ci-robot · web-flow · commit e3bb757129ce · 2024-04-01T14:19:35.000-07:00
svm test: wait after updating CRD to avoid flakes
diff --git a/test/integration/storageversionmigrator/util.go b/test/integration/storageversionmigrator/util.go
@@ -773,6 +773,10 @@ func (svm *svmTest) updateCRD(
 		t.Fatalf("Failed to get CRD: %v", err)
 	}
 
+	// TODO: wrap all actions after updateCRD with wait loops so we do not need this sleep
+	//  it is currently necessary because we update the CRD but do not otherwise guarantee that the updated config is active
+	time.Sleep(10 * time.Second)
+
 	return crd
 }
 

Original file line number	Diff line number	Diff line change
`@@ -773,6 +773,10 @@ func (svm *svmTest) updateCRD(`
`773`	`773`	`t.Fatalf("Failed to get CRD: %v", err)`
`774`	`774`	`}`
`775`	`775`
	`776`	`+ // TODO: wrap all actions after updateCRD with wait loops so we do not need this sleep`
	`777`	`+ // it is currently necessary because we update the CRD but do not otherwise guarantee that the updated config is active`
	`778`	`+ time.Sleep(10 * time.Second)`
	`779`	`+`
`776`	`780`	`return crd`
`777`	`781`	`}`
`778`	`782`