Skip to content

Commit e609926

Browse files
authored
Merge pull request kubernetes#125080 from TommyStarK/unit-tests/kubelet-apis-config-validation
kubelet/apis/config/validation: improve unit test coverage
2 parents f5b9290 + 3c57c20 commit e609926

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

pkg/kubelet/apis/config/validation/validation_test.go

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,6 +635,27 @@ func TestValidateKubeletConfiguration(t *testing.T) {
635635
return config
636636
},
637637
errMsg: `invalid configuration: pod logs path "/🧪" mut contains ASCII characters only`,
638+
}, {
639+
name: "invalid ContainerRuntimeEndpoint",
640+
configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration {
641+
conf.ContainerRuntimeEndpoint = ""
642+
return conf
643+
},
644+
errMsg: "invalid configuration: the containerRuntimeEndpoint was not specified or empty",
645+
}, {
646+
name: "invalid Logging configuration",
647+
configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration {
648+
conf.Logging.Format = "invalid"
649+
return conf
650+
},
651+
errMsg: "logging.format: Invalid value: \"invalid\": Unsupported log format",
652+
}, {
653+
name: "invalid FeatureGate",
654+
configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration {
655+
conf.FeatureGates["invalid"] = true
656+
return conf
657+
},
658+
errMsg: "unrecognized feature gate: invalid",
638659
},
639660
}
640661

0 commit comments

Comments
 (0)