Skip to content

Commit eb6fece

Browse files
authored
Merge pull request kubernetes#121768 from borg-land/deadcode
test: introduce a Feature label for skipping KubeUp specific tests
2 parents e4b74dd + 76277f6 commit eb6fece

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

test/e2e/autoscaling/dns_autoscaling.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
"k8s.io/apimachinery/pkg/labels"
3030
"k8s.io/apimachinery/pkg/util/wait"
3131
clientset "k8s.io/client-go/kubernetes"
32+
"k8s.io/kubernetes/test/e2e/feature"
3233
"k8s.io/kubernetes/test/e2e/framework"
3334
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3435
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
@@ -104,7 +105,8 @@ var _ = SIGDescribe("DNS horizontal autoscaling", func() {
104105

105106
// This test is separated because it is slow and need to run serially.
106107
// Will take around 5 minutes to run on a 4 nodes cluster.
107-
f.It(f.WithSerial(), f.WithSlow(), "kube-dns-autoscaler should scale kube-dns pods when cluster size changed", func(ctx context.Context) {
108+
// TODO(upodroid) This test will be removed in 1.33 when kubeup is removed
109+
f.It(f.WithSerial(), f.WithSlow(), feature.KubeUp, "kube-dns-autoscaler should scale kube-dns pods when cluster size changed", func(ctx context.Context) {
108110
numNodes, err := e2enode.TotalRegistered(ctx, c)
109111
framework.ExpectNoError(err)
110112

test/e2e/feature/feature.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ var (
7171
KubeProxyDaemonSetDowngrade = framework.WithFeature(framework.ValidFeatures.Add("KubeProxyDaemonSetDowngrade"))
7272
KubeProxyDaemonSetUpgrade = framework.WithFeature(framework.ValidFeatures.Add("KubeProxyDaemonSetUpgrade"))
7373
KubeProxyDaemonSetMigration = framework.WithFeature(framework.ValidFeatures.Add("KubeProxyDaemonSetMigration"))
74+
KubeUp = framework.WithFeature(framework.ValidFeatures.Add("KubeUp"))
7475
LabelSelector = framework.WithFeature(framework.ValidFeatures.Add("LabelSelector"))
7576
LocalStorageCapacityIsolation = framework.WithFeature(framework.ValidFeatures.Add("LocalStorageCapacityIsolation"))
7677
LocalStorageCapacityIsolationQuota = framework.WithFeature(framework.ValidFeatures.Add("LocalStorageCapacityIsolationQuota"))

0 commit comments

Comments
 (0)