Skip to content

Commit eeae981

Browse files
committed
set LocalStorageCapacityIsolationFSQuotaMonitoring to false by default
as the feature relies on UserNamespaces support, which is also off by default. Having it on by default won't do anything negative, except adding some needless checks as to whether the pod has hostUsers==true (impossible without the feature gate) Signed-off-by: Peter Hunt <[email protected]>
1 parent 696ad19 commit eeae981

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/features/kube_features.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,9 +429,11 @@ const (
429429

430430
// owner: @RobertKrawitz
431431
// alpha: v1.15
432+
// beta: v1.31
432433
//
433434
// Allow use of filesystems for ephemeral storage monitoring.
434435
// Only applies if LocalStorageCapacityIsolation is set.
436+
// Relies on UserNamespacesSupport feature, and thus should follow it when setting defaults.
435437
LocalStorageCapacityIsolationFSQuotaMonitoring featuregate.Feature = "LocalStorageCapacityIsolationFSQuotaMonitoring"
436438

437439
// owner: @damemi
@@ -1099,7 +1101,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
10991101

11001102
LegacyServiceAccountTokenCleanUp: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.30; remove in 1.32
11011103

1102-
LocalStorageCapacityIsolationFSQuotaMonitoring: {Default: true, PreRelease: featuregate.Beta},
1104+
LocalStorageCapacityIsolationFSQuotaMonitoring: {Default: false, PreRelease: featuregate.Beta},
11031105

11041106
LogarithmicScaleDown: {Default: true, PreRelease: featuregate.GA, LockToDefault: true},
11051107

0 commit comments

Comments
 (0)