Merge pull request kubernetes#129870 from yongruilin/fix-componentstatus-500

chore: use NewNotFound error for missing components

Author: k8s-ci-robot

pkg/registry/core/componentstatus/rest.go

@@ -18,14 +18,14 @@ package componentstatus
 
 import (
 	"context"
-	"fmt"
 	"sync"
 
 	"k8s.io/apimachinery/pkg/fields"
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apiserver/pkg/registry/generic"
 	"k8s.io/apiserver/pkg/storage"
 
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metainternalversion "k8s.io/apimachinery/pkg/apis/meta/internalversion"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -136,7 +136,7 @@ func (rs *REST) Get(ctx context.Context, name string, options *metav1.GetOptions
 	servers := rs.GetServersToValidate()
 
 	if server, ok := servers[name]; !ok {
-		return nil, fmt.Errorf("Component not found: %s", name)
+		return nil, apierrors.NewNotFound(api.Resource("componentstatus"), name)
 	} else {
 		return rs.getComponentStatus(name, server), nil
 	}

pkg/registry/core/componentstatus/rest_test.go

@@ -177,7 +177,7 @@ func TestGet_BadName(t *testing.T) {
 	if err == nil {
 		t.Fatalf("Expected error, but did not get one")
 	}
-	if !strings.Contains(err.Error(), "Component not found: invalidname") {
+	if !strings.Contains(err.Error(), `componentstatus "invalidname" not found`) {
 		t.Fatalf("Got unexpected error: %v", err)
 	}
 }