fix a scheduler preemption issue that victim is not patched properly

Huang-Wei · Huang-Wei · commit f6a11da27987 · 2024-08-12T15:25:10.000-07:00
diff --git a/pkg/scheduler/framework/preemption/preemption.go b/pkg/scheduler/framework/preemption/preemption.go
@@ -366,7 +366,7 @@ func (ev *Evaluator) prepareCandidate(ctx context.Context, c Candidate, pod *v1.
 				Reason:  v1.PodReasonPreemptionByScheduler,
 				Message: fmt.Sprintf("%s: preempting to accommodate a higher priority pod", pod.Spec.SchedulerName),
 			}
-			newStatus := pod.Status.DeepCopy()
+			newStatus := victim.Status.DeepCopy()
 			updated := apipod.UpdatePodCondition(newStatus, condition)
 			if updated {
 				if err := util.PatchPodStatus(ctx, cs, victim, newStatus); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ func (ev Evaluator) prepareCandidate(ctx context.Context, c Candidate, pod v1.`
`366`	`366`	`Reason: v1.PodReasonPreemptionByScheduler,`
`367`	`367`	`Message: fmt.Sprintf("%s: preempting to accommodate a higher priority pod", pod.Spec.SchedulerName),`
`368`	`368`	`}`
`369`		`- newStatus := pod.Status.DeepCopy()`
	`369`	`+ newStatus := victim.Status.DeepCopy()`
`370`	`370`	`updated := apipod.UpdatePodCondition(newStatus, condition)`
`371`	`371`	`if updated {`
`372`	`372`	`if err := util.PatchPodStatus(ctx, cs, victim, newStatus); err != nil {`