Skip to content

Commit f762e5c

Browse files
committed
Remove an unnecessary comment in nftables output
(It's redundant with the chain name.)
1 parent 11f55ea commit f762e5c

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

pkg/proxy/nftables/proxier.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1364,7 +1364,6 @@ func (proxier *Proxier) syncProxyRules() {
13641364
Value: []string{
13651365
fmt.Sprintf("goto %s", fwChain),
13661366
},
1367-
Comment: &svcPortNameString,
13681367
})
13691368
}
13701369
}

pkg/proxy/nftables/proxier_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ func TestOverallNFTablesRules(t *testing.T) {
445445
add element ip kube-proxy service-ips { 172.30.0.45 . tcp . 80 : goto service-HVFWP5L3-ns5/svc5/tcp/p80 }
446446
add element ip kube-proxy service-ips { 5.6.7.8 . tcp . 80 : goto external-HVFWP5L3-ns5/svc5/tcp/p80 }
447447
add element ip kube-proxy service-nodeports { tcp . 3002 : goto external-HVFWP5L3-ns5/svc5/tcp/p80 }
448-
add element ip kube-proxy firewall-ips { 5.6.7.8 . tcp . 80 comment "ns5/svc5:p80" : goto firewall-HVFWP5L3-ns5/svc5/tcp/p80 }
448+
add element ip kube-proxy firewall-ips { 5.6.7.8 . tcp . 80 : goto firewall-HVFWP5L3-ns5/svc5/tcp/p80 }
449449
450450
# svc6
451451
add element ip kube-proxy cluster-ips { 172.30.0.46 }

0 commit comments

Comments
 (0)