apiserver/storage: storagetesting.RunTestList validates RemainingItemCount

p0lyn0mial · p0lyn0mial · commit f9b15700fb5a · 2024-06-27T11:06:15.000+02:00
diff --git a/staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go b/staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
@@ -28,6 +28,7 @@ import (
 	"sync"
 	"testing"
 
+	"github.com/google/go-cmp/cmp"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/fields"
@@ -1246,6 +1247,9 @@ func RunTestList(ctx context.Context, t *testing.T, store storage.Interface, com
 			} else {
 				ExpectContains(t, "incorrect list pods", toInterfaceSlice(tt.expectedAlternatives), out.Items)
 			}
+			if !cmp.Equal(tt.expectedRemainingItemCount, out.RemainingItemCount) {
+				t.Fatalf("unexpected remainingItemCount, diff: %s", cmp.Diff(tt.expectedRemainingItemCount, out.RemainingItemCount))
+			}
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ import (`
`28`	`28`	`"sync"`
`29`	`29`	`"testing"`
`30`	`30`
	`31`	`+ "github.com/google/go-cmp/cmp"`
`31`	`32`	`apierrors "k8s.io/apimachinery/pkg/api/errors"`
`32`	`33`	`metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"`
`33`	`34`	`"k8s.io/apimachinery/pkg/fields"`
`@@ -1246,6 +1247,9 @@ func RunTestList(ctx context.Context, t *testing.T, store storage.Interface, com`
`1246`	`1247`	`} else {`
`1247`	`1248`	`ExpectContains(t, "incorrect list pods", toInterfaceSlice(tt.expectedAlternatives), out.Items)`
`1248`	`1249`	`}`
	`1250`	`+ if !cmp.Equal(tt.expectedRemainingItemCount, out.RemainingItemCount) {`
	`1251`	`+ t.Fatalf("unexpected remainingItemCount, diff: %s", cmp.Diff(tt.expectedRemainingItemCount, out.RemainingItemCount))`
	`1252`	`+ }`
`1249`	`1253`	`})`
`1250`	`1254`	`}`
`1251`	`1255`	`}`