feat: Upgrade build to use tsup to properly support ESM and CJS

Author: yorch

.eslintrc.js .eslintrc.cjs.eslintrc.js renamed to .eslintrc.cjs

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 yarn lint-staged

.husky/pre-commit

@@ -9,15 +9,15 @@ module.exports = {
         {
             files: '*.json',
             options: {
-                tabWidth: 2,
-            },
+                tabWidth: 2
+            }
         },
         {
             files: '*.yml',
             options: {
-                tabWidth: 2,
-            },
-        },
+                tabWidth: 2
+            }
+        }
     ],
     editorconfig: true
 };

.prettierrc.js .prettierrc.cjs.prettierrc.js renamed to .prettierrc.cjs

@@ -2,7 +2,10 @@
   "name": "simple-sms-sender",
   "version": "0.1.1",
   "description": "Simple SMS sender to multiple recipients using Twilio",
-  "main": "dist/index.js",
+  "main": "dist/index.cjs",
+  "module": "dist/index.js",
+  "types": "dist/index.d.ts",
+  "type": "module",
   "author": "Jorge Barnaby <jorge.barnaby@gmail.com>",
   "license": "MIT",
   "homepage": "https://github.com/yorch/simple-sms-sender#readme",
@@ -14,9 +17,7 @@
     "url": "https://github.com/yorch/simple-sms-sender"
   },
   "scripts": {
-    "build": "run check && run build:ts",
-    "build:ts": "tsc --declaration",
-    "build:watch": "tsc -w",
+    "build": "run check && tsup",
     "test": "vitest --run",
     "test:watch": "vitest",
     "test:coverage": "vitest run --coverage",
@@ -36,6 +37,9 @@
     "twilio": "^4.23.0"
   },
   "devDependencies": {
+    "@microsoft/api-extractor": "7.52.2",
+    "@tsconfig/node-lts": "22.0.1",
+    "@tsconfig/strictest": "2.0.5",
     "@types/node": "20.17.30",
     "@typescript-eslint/eslint-plugin": "6.21.0",
     "@typescript-eslint/parser": "6.21.0",
@@ -47,7 +51,7 @@
     "lint-staged": "15.5.0",
     "prettier": "3.5.3",
     "rimraf": "6.0.1",
-    "ts-node": "10.9.2",
+    "tsup": "8.4.0",
     "typescript": "5.8.2",
     "vitest": "3.1.1",
     "yarn-or-npm": "3.0.1"

package.json

@@ -1,6 +1,6 @@
 import { describe, expect, test, vi } from 'vitest';
 
-import { SmsSender } from '../src/SmsSender';
+import { SmsSender } from './SmsSender.js';
 
 vi.mock('twilio', () => ({
     default: vi.fn(() => ({
@@ -55,7 +55,7 @@ describe('SmsSender', () => {
         const smsSender = new SmsSender({ ...commonConfig });
         await expect(
             smsSender.sendSms({
-                body: undefined,
+                body: '',
                 recipients: ['+19991112223333']
             })
         ).rejects.toThrowError('No body to send SMS');
@@ -66,7 +66,7 @@ describe('SmsSender', () => {
         await expect(
             smsSender.sendSms({
                 body: 'Test',
-                recipients: undefined
+                recipients: []
             })
         ).rejects.toThrowError('No recipients to send SMS');
         await expect(

src/SmsSender.test.ts

@@ -1,6 +1,5 @@
-import twilio from 'twilio';
-import type Twilio from 'twilio/lib/rest/Twilio';
-import type { GenericLogger, Message } from './types';
+import twilio, { type Twilio } from 'twilio';
+import type { GenericLogger, Message } from './types.js';
 
 export class SmsSender {
     private accountSid: string;
@@ -47,7 +46,7 @@ export class SmsSender {
         }
 
         const sendSmsToNumber = async (phoneNumber?: string) => {
-            const to = phoneNumber.trim();
+            const to = phoneNumber?.trim();
 
             if (!to) {
                 this.logger.error('Not a valid phone number to send SMS');
@@ -82,6 +81,8 @@ export class SmsSender {
                     error
                 );
             }
+
+            return;
         };
 
         return Promise.all(recipients.map(sendSmsToNumber));

src/SmsSender.ts

@@ -1 +1 @@
-export { SmsSender } from './SmsSender';
+export { SmsSender } from './SmsSender.js';

src/index.ts

@@ -1,22 +1,11 @@
 {
+  "extends": [
+    "@tsconfig/node-lts/tsconfig.json",
+    "@tsconfig/strictest/tsconfig.json"
+  ],
   "compilerOptions": {
-    "module": "commonjs",
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
-    "target": "es6",
-    "noImplicitAny": true,
-    "moduleResolution": "node",
-    "sourceMap": true,
-    "outDir": "dist",
-    "baseUrl": ".",
-    "paths": {
-      "*": [
-        "node_modules/*",
-        "src/types/*"
-      ]
-    }
+    "noEmit": true,
+    "baseUrl": "."
   },
-  "include": [
-    "src/**/*"
-  ]
+  "include": ["src/**/*"]
 }

tsconfig.json

@@ -0,0 +1,10 @@
+import { defineConfig } from 'tsup';
+
+export default defineConfig({
+    entry: ['src/index.ts'],
+    experimentalDts: true,
+    format: ['cjs', 'esm'],
+    splitting: false,
+    sourcemap: false,
+    clean: true
+});