feat: link icon and metadata (#1171)

xelavopelk · web-flow · commit d9ad4dba3a89 · 2025-12-02T15:42:28.000+05:30
diff --git a/src/config/icon/icon.go b/src/config/icon/icon.go
@@ -108,6 +108,7 @@ var Icons = map[string]Style{
 	"ko":           {Icon: "\uebc6", Color: "#9b59b6"},     // Printable Rune : ""
 	"kt":           {Icon: "\ue634", Color: "#2980b9"},     // Printable Rune : ""
 	"less":         {Icon: "\ue758", Color: "#3498db"},     // Printable Rune : ""
+	"link_file":    {Icon: "\uf481", Color: "NONE"},        // Printable Rune : ""
 	"lock":         {Icon: "\uf023", Color: "#f1c40f"},     // Printable Rune : ""
 	"log":          {Icon: "\uf18d", Color: "#7f8c8d"},     // Printable Rune : ""
 	"lua":          {Icon: "\ue620", Color: "#e74c3c"},     // Printable Rune : ""
@@ -418,6 +419,7 @@ var Folders = map[string]Style{
 	// Item for Generic folder, with key "folder" is initialized in InitIcon()
 	"hidden":       {Icon: "\uf023", Color: "#75715e"}, // Hidden folder - Dark yellowish // Printable Rune : ""
 	"node_modules": {Icon: "\ue5fa", Color: "#cb3837"}, // Node modules folder - Red // Printable Rune : ""
+	"link_folder":  {Icon: "\uf482", Color: "NONE"},    // link folder - None // Printable Rune : ""
 
 	"superfile": {Icon: "\U000f069d", Color: "#FF6F00"}, // Printable Rune : "󰚝"
 }
diff --git a/src/internal/common/icon_utils.go b/src/internal/common/icon_utils.go
@@ -7,25 +7,11 @@ import (
 	"github.com/yorukot/superfile/src/config/icon"
 )
 
-func GetElementIcon(file string, isDir bool, nerdFont bool) icon.Style {
-	ext := strings.TrimPrefix(filepath.Ext(file), ".")
-	name := file
-
-	if !nerdFont {
-		return icon.Style{
-			Icon:  "",
-			Color: Theme.FilePanelFG,
-		}
-	}
-
-	if isDir {
-		resultIcon := icon.Folders["folder"]
-		betterIcon, hasBetterIcon := icon.Folders[name]
-		if hasBetterIcon {
-			resultIcon = betterIcon
-		}
-		return resultIcon
+func getFileIcon(file string, isLink bool) icon.Style {
+	if isLink {
+		return icon.Icons["link_file"]
 	}
+	ext := strings.TrimPrefix(filepath.Ext(file), ".")
 	// default icon for all files. try to find a better one though...
 	resultIcon := icon.Icons["file"]
 	// resolve aliased extensions
@@ -42,7 +28,7 @@ func GetElementIcon(file string, isDir bool, nerdFont bool) icon.Style {
 	}
 
 	// now look for icons based on full names
-	fullName := name
+	fullName := file
 
 	fullName = strings.ToLower(fullName)
 	fullAlias, hasFullAlias := icon.Aliases[fullName]
@@ -61,3 +47,26 @@ func GetElementIcon(file string, isDir bool, nerdFont bool) icon.Style {
 	}
 	return resultIcon
 }
+
+func GetElementIcon(file string, isDir bool, isLink bool, nerdFont bool) icon.Style {
+	if !nerdFont {
+		return icon.Style{
+			Icon:  "",
+			Color: Theme.FilePanelFG,
+		}
+	}
+
+	if isDir {
+		if isLink {
+			return icon.Folders["link_folder"]
+		}
+		resultIcon := icon.Folders["folder"]
+		betterIcon, hasBetterIcon := icon.Folders[file]
+		if hasBetterIcon {
+			resultIcon = betterIcon
+		}
+		return resultIcon
+	}
+
+	return getFileIcon(file, isLink)
+}
diff --git a/src/internal/common/icon_utils_test.go b/src/internal/common/icon_utils_test.go
@@ -11,13 +11,15 @@ func TestGetElementIcon(t *testing.T) {
 		name     string
 		file     string
 		isDir    bool
+		isLink   bool
 		nerdFont bool
 		expected icon.Style
 	}{
 		{
 			name:     "Non-nerdfont returns empty icon",
 			file:     "test.txt",
 			isDir:    false,
+			isLink:   false,
 			nerdFont: false,
 			expected: icon.Style{
 				Icon:  "",
@@ -28,48 +30,55 @@ func TestGetElementIcon(t *testing.T) {
 			name:     "Directory with nerd font",
 			file:     "folder",
 			isDir:    true,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Folders["folder"],
 		},
 		{
 			name:     "File with known extension",
 			file:     "test.js",
 			isDir:    false,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Icons["js"],
 		},
 		{
 			name:     "Full name takes priority over extension",
 			file:     "gulpfile.js",
 			isDir:    false,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Icons["gulpfile.js"],
 		},
 		{
 			name:     ".git directory",
 			file:     ".git",
 			isDir:    true,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Folders[".git"],
 		},
 		{
 			name:     "superfile directory",
 			file:     "superfile",
 			isDir:    true,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Folders["superfile"],
 		},
 		{
 			name:     "package.json file",
 			file:     "package.json",
 			isDir:    false,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Icons["package"],
 		},
 		{
 			name:     "File with unknown extension",
 			file:     "test.xyz",
 			isDir:    false,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Style{
 				Icon: icon.Icons["file"].Icon,
@@ -81,14 +90,31 @@ func TestGetElementIcon(t *testing.T) {
 			name:     "File with aliased name",
 			file:     "dockerfile",
 			isDir:    false,
+			isLink:   false,
 			nerdFont: true,
 			expected: icon.Icons["dockerfile"],
 		},
+		{
+			name:     "Link to Directory with nerd font",
+			file:     "folder",
+			isDir:    true,
+			isLink:   true,
+			nerdFont: true,
+			expected: icon.Folders["link_folder"],
+		},
+		{
+			name:     "Link to File",
+			file:     "test.js",
+			isDir:    false,
+			isLink:   true,
+			nerdFont: true,
+			expected: icon.Icons["link_file"],
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			result := GetElementIcon(tt.file, tt.isDir, tt.nerdFont)
+			result := GetElementIcon(tt.file, tt.isDir, tt.isLink, tt.nerdFont)
 			if result.Icon != tt.expected.Icon || result.Color != tt.expected.Color {
 				t.Errorf("GetElementIcon() = %v, want %v", result, tt.expected)
 			}
diff --git a/src/internal/common/string_function.go b/src/internal/common/string_function.go
@@ -58,8 +58,8 @@ func TruncateMiddleText(text string, maxChars int, tails string) string {
 	return truncatedText
 }
 
-func PrettierName(name string, width int, isDir bool, isSelected bool, bgColor lipgloss.Color) string {
-	style := GetElementIcon(name, isDir, Config.Nerdfont)
+func PrettierName(name string, width int, isDir bool, isLink bool, isSelected bool, bgColor lipgloss.Color) string {
+	style := GetElementIcon(name, isDir, isLink, Config.Nerdfont)
 	if isSelected {
 		return StringColorRender(lipgloss.Color(style.Color), bgColor).
 			Background(bgColor).
@@ -73,16 +73,16 @@ func PrettierName(name string, width int, isDir bool, isSelected bool, bgColor l
 		FilePanelStyle.Render(TruncateText(name, width, "..."))
 }
 
-func PrettierDirectoryPreviewName(name string, isDir bool, bgColor lipgloss.Color) string {
-	style := GetElementIcon(name, isDir, Config.Nerdfont)
+func PrettierDirectoryPreviewName(name string, isDir bool, isLink bool, bgColor lipgloss.Color) string {
+	style := GetElementIcon(name, isDir, isLink, Config.Nerdfont)
 	return StringColorRender(lipgloss.Color(style.Color), bgColor).
 		Background(bgColor).
 		Render(style.Icon+" ") +
 		FilePanelStyle.Render(name)
 }
 
-func ClipboardPrettierName(name string, width int, isDir bool, isSelected bool) string {
-	style := GetElementIcon(filepath.Base(name), isDir, Config.Nerdfont)
+func ClipboardPrettierName(name string, width int, isDir bool, isLink bool, isSelected bool) string {
+	style := GetElementIcon(filepath.Base(name), isDir, isLink, Config.Nerdfont)
 	if isSelected {
 		return StringColorRender(lipgloss.Color(style.Color), FooterBGColor).
 			Background(FooterBGColor).
diff --git a/src/internal/model_render.go b/src/internal/model_render.go
@@ -136,10 +136,12 @@ func (panel *filePanel) renderFileEntries(r *rendering.Renderer, mainPanelHeight
 		// Calculate the actual prefix width for proper alignment
 		prefixWidth := lipgloss.Width(cursor+" ") + lipgloss.Width(selectBox)
 
+		isLink := panel.element[i].info.Mode()&os.ModeSymlink != 0
 		renderedName := common.PrettierName(
 			panel.element[i].name,
 			filePanelWidth-prefixWidth,
 			panel.element[i].directory,
+			isLink,
 			isSelected,
 			common.FilePanelBGColor,
 		)
@@ -222,15 +224,16 @@ func (m *model) clipboardRender() string {
 				// Last Entry we can render, but there are more that one left
 				r.AddLines(strconv.Itoa(len(m.copyItems.items)-i) + " item left....")
 			} else {
-				fileInfo, err := os.Stat(m.copyItems.items[i])
+				fileInfo, err := os.Lstat(m.copyItems.items[i])
 				if err != nil {
 					slog.Error("Clipboard render function get item state ", "error", err)
 				}
 				if !os.IsNotExist(err) {
+					isLink := fileInfo.Mode()&os.ModeSymlink != 0
 					// TODO : There is an inconsistency in parameter that is being passed,
 					// and its name in ClipboardPrettierName function
 					r.AddLines(common.ClipboardPrettierName(m.copyItems.items[i],
-						utils.FooterWidth(m.fullWidth)-3, fileInfo.IsDir(), false))
+						utils.FooterWidth(m.fullWidth)-3, fileInfo.IsDir(), isLink, false))
 				}
 			}
 		}
diff --git a/src/internal/ui/metadata/const.go b/src/internal/ui/metadata/const.go
@@ -5,7 +5,6 @@ const keyValueSpacing = " "
 const keyValueSpacingLen = 1
 
 const fileStatErrorMsg = "Cannot load file stats"
-const linkFileMsg = "This is a link file."
 const linkFileBrokenMsg = "Link file is broken!"
 const etFetchErrorMsg = "Errors while fetching metadata via exiftool"
 
@@ -17,6 +16,7 @@ const keyPermissions = "Permissions"
 const keyMd5Checksum = "MD5Checksum"
 const keyOwner = "Owner"
 const keyGroup = "Group"
+const keyPath = "Path"
 
 var sortPriority = map[string]int{ //nolint: gochecknoglobals // This is effectively const.
 	keyName:         0,
@@ -26,4 +26,5 @@ var sortPriority = map[string]int{ //nolint: gochecknoglobals // This is effecti
 	keyPermissions:  4,
 	keyOwner:        5,
 	keyGroup:        6,
+	keyPath:         7,
 }
diff --git a/src/internal/ui/metadata/metadata.go b/src/internal/ui/metadata/metadata.go
@@ -80,6 +80,20 @@ func GetMetadata(filePath string, metadataFocussed bool, et *exiftool.Exiftool)
 	return meta
 }
 
+func getSymLinkMetaData(filePath string) Metadata {
+	res := Metadata{
+		filepath: filePath,
+	}
+	linkPath, symlinkErr := filepath.EvalSymlinks(filePath)
+	if symlinkErr != nil {
+		res.infoMsg = linkFileBrokenMsg
+	} else {
+		path := [2]string{keyPath, linkPath}
+		res.data = append(res.data, path)
+	}
+	return res
+}
+
 func getMetaDataUnsorted(filePath string, metadataFocussed bool, et *exiftool.Exiftool) Metadata {
 	res := Metadata{
 		filepath: filePath,
@@ -91,13 +105,7 @@ func getMetaDataUnsorted(filePath string, metadataFocussed bool, et *exiftool.Ex
 		return res
 	}
 	if fileInfo.Mode()&os.ModeSymlink != 0 {
-		_, symlinkErr := filepath.EvalSymlinks(filePath)
-		if symlinkErr != nil {
-			res.infoMsg = linkFileBrokenMsg
-		} else {
-			res.infoMsg = linkFileMsg
-		}
-		return res
+		return getSymLinkMetaData(filePath)
 	}
 	// Add basic metadata information irrespective of what is fetched from exiftool
 	// Note : we prioritize these while sorting Metadata
diff --git a/src/internal/ui/preview/model.go b/src/internal/ui/preview/model.go
@@ -151,7 +151,11 @@ func renderDirectoryPreview(r *rendering.Renderer, itemPath string, previewHeigh
 
 	for i := 0; i < previewHeight && i < len(files); i++ {
 		file := files[i]
-		style := common.GetElementIcon(file.Name(), file.IsDir(), common.Config.Nerdfont)
+		isLink := false
+		if info, err := file.Info(); err == nil {
+			isLink = info.Mode()&os.ModeSymlink != 0
+		}
+		style := common.GetElementIcon(file.Name(), file.IsDir(), isLink, common.Config.Nerdfont)
 		res := lipgloss.NewStyle().Foreground(lipgloss.Color(style.Color)).Background(common.FilePanelBGColor).
 			Render(style.Icon+" ") + common.FilePanelStyle.Render(file.Name())
 		r.AddLines(res)
