Skip to content

Commit 81cda1e

Browse files
authored
chore: address review feedback from 14381 (googleapis#14425)
This PR addresses the following feedback from googleapis#14381 - googleapis#14381 (comment) - googleapis#14381 (comment) - googleapis#14381 (comment)
1 parent 945888f commit 81cda1e

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

.generator/cli.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -849,8 +849,8 @@ def handle_release_init(
849849
850850
Raises:
851851
ValueError: if the version in `release-init-request.json` is
852-
the same as the version in state.yaml
853-
ValueError: if the `release-init-request.json` file in the given
852+
the same as the version in state.yaml or if the
853+
`release-init-request.json` file in the given
854854
librarian directory cannot be read.
855855
"""
856856

@@ -880,8 +880,7 @@ def handle_release_init(
880880
if previous_version == version:
881881
raise ValueError(
882882
f"The version in {RELEASE_INIT_REQUEST_FILE} is the same as the version in {STATE_YAML_FILE}\n"
883-
f"{library_id} previous released version: {previous_version}\n"
884-
f"{library_id} current version: {version}\n"
883+
f"{library_id} version: {previous_version}\n"
885884
)
886885

887886
_update_version_for_library(repo, output, path_to_library, version)

.generator/test_cli.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -615,13 +615,6 @@ def test_handle_release_init_fail_value_error_version(mocker):
615615

616616
mock_release_init_request_content = {
617617
"libraries": [
618-
{
619-
"id": "google-cloud-another-library",
620-
"apis": [{"path": "google/cloud/another/library/v1"}],
621-
"release_triggered": False,
622-
"version": "1.2.3",
623-
"changes": [],
624-
},
625618
{
626619
"id": "google-cloud-language",
627620
"apis": [{"path": "google/cloud/language/v1"}],

0 commit comments

Comments
 (0)