Avoid set changed size during iteration (RustPython#5860)

Author: moreal

Lib/test/test_set.py

@@ -582,8 +582,6 @@ def test_ixor(self):
             else:
                 self.assertNotIn(c, self.s)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_inplace_on_self(self):
         t = self.s.copy()
         t |= t

vm/src/builtins/set.rs

@@ -426,8 +426,9 @@ impl PySetInner {
         vm: &VirtualMachine,
     ) -> PyResult<()> {
         for iterable in others {
-            for item in iterable.iter(vm)? {
-                self.content.delete_if_exists(vm, &*item?)?;
+            let items = iterable.iter(vm)?.collect::<Result<Vec<_>, _>>()?;
+            for item in items {
+                self.content.delete_if_exists(vm, &*item)?;
             }
         }
         Ok(())