windows umask, win32_xstat_slow_impl, fake EXT_SUFFIX (RustPython#6340)

* umask

* EXT_SUFFIX

* File Attributes and win32_xstat_slow_impl

* unmark tests

Author: youknowone

.cspell.dict/cpython.txt

@@ -46,6 +46,7 @@ prec
 preinitialized
 PYTHREAD_NAME
 SA_ONSTACK
+SOABI
 stackdepth
 stringlib
 structseq

Lib/test/test_genericpath.py

@@ -352,13 +352,6 @@ def test_invalid_paths(self):
                     with self.assertRaisesRegex(ValueError, 'embedded null'):
                         func(b'/tmp\x00abcds')
 
-    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
-    def test_samestat_on_symlink(self):
-        return super().test_samestat_on_symlink()
-
-    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
-    def test_samefile_on_symlink(self):
-        return super().test_samefile_on_symlink()
 
 # Following TestCase is not supposed to be run from test_genericpath.
 # It is inherited by other test modules (ntpath, posixpath).

Lib/test/test_logging.py

@@ -6384,7 +6384,6 @@ def rotator(source, dest):
         rh.close()
 
 class TimedRotatingFileHandlerTest(BaseFileTest):
-    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
     @unittest.skipIf(support.is_wasi, "WASI does not have /dev/null.")
     def test_should_not_rollover(self):
         # See bpo-45401. Should only ever rollover regular files

Lib/test/test_ntpath.py

@@ -1458,8 +1458,6 @@ def test_isfile_named_pipe(self):
         finally:
             _winapi.CloseHandle(h)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     @unittest.skipIf(sys.platform != 'win32', "windows only")
     def test_con_device(self):
         self.assertFalse(os.path.isfile(r"\\.\CON"))
@@ -1527,14 +1525,6 @@ def test_expandvars(self):
     def test_expandvars_nonascii(self):
         return super().test_expandvars_nonascii()
 
-    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
-    def test_samefile_on_symlink(self):
-        return super().test_samefile_on_symlink()
-
-    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
-    def test_samestat_on_symlink(self):
-        return super().test_samestat_on_symlink()
-
 
 class PathLikeTests(NtpathTestCase):
 

Lib/test/test_shutil.py

@@ -1476,7 +1476,6 @@ def test_dont_copy_file_onto_link_to_itself(self):
         finally:
             shutil.rmtree(TESTFN, ignore_errors=True)
 
-    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON; AssertionError: SameFileError not raised for copyfile')
     @os_helper.skip_unless_symlink
     def test_dont_copy_file_onto_symlink_to_itself(self):
         # bug 851123.
@@ -2577,7 +2576,6 @@ def test_destinsrc_false_positive(self):
         finally:
             os_helper.rmtree(TESTFN)
 
-    @unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
     @os_helper.skip_unless_symlink
     @mock_rename
     def test_move_file_symlink(self):
@@ -2587,7 +2585,6 @@ def test_move_file_symlink(self):
         self.assertTrue(os.path.islink(self.dst_file))
         self.assertTrue(os.path.samefile(self.src_file, self.dst_file))
 
-    @unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
     @os_helper.skip_unless_symlink
     @mock_rename
     def test_move_file_symlink_to_dir(self):
@@ -2611,7 +2608,6 @@ def test_move_dangling_symlink(self):
         self.assertTrue(os.path.islink(dst_link))
         self.assertEqual(os.path.realpath(src), os.path.realpath(dst_link))
 
-    @unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
     @os_helper.skip_unless_symlink
     @mock_rename
     def test_move_dir_symlink(self):
@@ -2687,12 +2683,10 @@ def _test_move_symlink_to_dir_into_dir(self, dst):
         self.assertTrue(os.path.samefile(self.dst_dir, dst_link))
         self.assertTrue(os.path.exists(src))
 
-    @unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
     @os_helper.skip_unless_symlink
     def test_move_symlink_to_dir_into_dir(self):
         self._test_move_symlink_to_dir_into_dir(self.dst_dir)
 
-    @unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
     @os_helper.skip_unless_symlink
     def test_move_symlink_to_dir_into_symlink_to_dir(self):
         dst = os.path.join(self.src_dir, 'otherlinktodir')

crates/vm/src/stdlib/nt.rs

@@ -475,6 +475,20 @@ pub(crate) mod module {
         Ok(())
     }
 
+    unsafe extern "C" {
+        fn _umask(mask: i32) -> i32;
+    }
+
+    #[pyfunction]
+    fn umask(mask: i32, vm: &VirtualMachine) -> PyResult<i32> {
+        let result = unsafe { _umask(mask) };
+        if result < 0 {
+            Err(errno_err(vm))
+        } else {
+            Ok(result)
+        }
+    }
+
     pub(crate) fn support_funcs() -> Vec<SupportFunc> {
         Vec::new()
     }

crates/vm/src/stdlib/sysconfig.rs

@@ -7,8 +7,19 @@ pub(crate) mod sysconfig {
     #[pyfunction]
     fn config_vars(vm: &VirtualMachine) -> PyDictRef {
         let vars = vm.ctx.new_dict();
+
+        // FIXME: This is an entirely wrong implementation of EXT_SUFFIX.
+        // EXT_SUFFIX must be a string starting with "." for pip compatibility
+        // Using ".pyd" causes pip's _generic_abi() to fall back to _cpython_abis()
+        vars.set_item("EXT_SUFFIX", ".pyd".to_pyobject(vm), vm)
+            .unwrap();
+        vars.set_item("SOABI", vm.ctx.none(), vm).unwrap();
+
         vars.set_item("Py_GIL_DISABLED", true.to_pyobject(vm), vm)
             .unwrap();
+        vars.set_item("Py_DEBUG", false.to_pyobject(vm), vm)
+            .unwrap();
+
         vars
     }
 }