refactor: record 미적용된 클래스 변경, @transactional 누락된 서비스 메서드 보완

Author: seulnan

src/main/java/com/yourssu/roomescape/member/MemberService.java

@@ -1,6 +1,7 @@
 package com.yourssu.roomescape.member;
 
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class MemberService {
@@ -10,6 +11,7 @@ public MemberService(MemberRepository memberRepository) {
         this.memberRepository = memberRepository;
     }
 
+    @Transactional
     public MemberResponse createMember(MemberRequest request) {
         Member member = new Member(request.name(), request.email(), request.password(), "USER");
         Member saved = memberRepository.save(member);

src/main/java/com/yourssu/roomescape/reservation/MyReservationResponse.java

@@ -2,23 +2,8 @@
 
 import com.yourssu.roomescape.reservation.waiting.Waiting;
 import com.yourssu.roomescape.reservation.waiting.WaitingWithRank;
-import lombok.Getter;
 
-@Getter
-public class MyReservationResponse {
-    private final Long reservationId;
-    private final String theme;
-    private final String date;
-    private final String time;
-    private final String status;
-
-    public MyReservationResponse(Long reservationId, String theme, String date, String time, String status) {
-        this.reservationId = reservationId;
-        this.theme = theme;
-        this.date = date;
-        this.time = time;
-        this.status = status;
-    }
+public record MyReservationResponse(Long reservationId, String theme, String date, String time, String status) {
 
     public static MyReservationResponse of(Reservation reservation) {
         return new MyReservationResponse(
@@ -31,8 +16,8 @@ public static MyReservationResponse of(Reservation reservation) {
     }
 
     public static MyReservationResponse fromWaiting(WaitingWithRank waitingWithRank) {
-        Waiting waiting = waitingWithRank.getWaiting();
-        String status = waitingWithRank.getRank() + "번째 예약대기";
+        Waiting waiting = waitingWithRank.waiting();
+        String status = waitingWithRank.rank() + "번째 예약대기";
         return new MyReservationResponse(
                 waiting.getId(),
                 waiting.getTheme().getName(),

src/main/java/com/yourssu/roomescape/reservation/ReservationService.java

@@ -42,6 +42,7 @@ public ReservationService(
         this.waitingRepository = waitingRepository;
     }
 
+    @Transactional
     public ReservationResponse save(ReservationRequest request, LoginMember loginMember) {
         Member member = (request.name() != null && !request.name().isBlank())
                 ? memberRepository.findByName(request.name())

src/main/java/com/yourssu/roomescape/reservation/waiting/WaitingWithRank.java

@@ -1,16 +1,5 @@
 package com.yourssu.roomescape.reservation.waiting;
 
-import lombok.Getter;
-
-@Getter
-public class WaitingWithRank {
-
-    private final Waiting waiting;
-    private final int rank;
-
-    public WaitingWithRank(Waiting waiting, int rank) {
-        this.waiting = waiting;
-        this.rank = rank;
-    }
+public record WaitingWithRank(Waiting waiting, int rank) {
 
 }

src/main/java/com/yourssu/roomescape/time/AvailableTime.java

@@ -1,17 +1,5 @@
 package com.yourssu.roomescape.time;
 
-import lombok.Getter;
-
-@Getter
-public class AvailableTime {
-    private Long timeId;
-    private String time;
-    private boolean booked;
-
-    public AvailableTime(Long timeId, String time, boolean booked) {
-        this.timeId = timeId;
-        this.time = time;
-        this.booked = booked;
-    }
+public record AvailableTime (Long timeId, String time, boolean booked){
 
 }

src/main/java/com/yourssu/roomescape/time/TimeService.java

@@ -3,6 +3,7 @@
 import com.yourssu.roomescape.reservation.Reservation;
 import com.yourssu.roomescape.reservation.ReservationRepository;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
@@ -16,6 +17,7 @@ public TimeService(TimeRepository timeRepository, ReservationRepository reservat
         this.reservationRepository = reservationRepository;
     }
 
+    @Transactional
     public List<AvailableTime> getAvailableTime(String date, Long themeId) {
         List<Reservation> reservations = reservationRepository.findByDateAndThemeId(date, themeId);
         List<Time> times = timeRepository.findByDeletedFalse();

src/test/java/com/yourssu/roomescape/MissionStepTest.java

@@ -159,10 +159,10 @@ private String createToken(String email, String password) {
 
         // 예약 대기 상태 확인
         String status = myReservations.stream()
-                .filter(it -> it.getReservationId().equals(waiting.id()))
-                .filter(it -> !it.getStatus().equals("예약"))
+                .filter(it -> it.reservationId().equals(waiting.id()))
+                .filter(it -> !it.status().equals("예약"))
                 .findFirst()
-                .map(it -> it.getStatus())
+                .map(it -> it.status())
                 .orElse(null);
 
         assertThat(status).isEqualTo("1번째 예약대기");