tvOS: Build own system_get_extensions.cc instead of the stub version (#9219)

This is groundwork for enabling the accessibility extension that will be
used with h5vcc_accessibility. For now, just get the file to build while
always returning nullptr for any extension:

* Remove checks for the configuration extension because the extension is
not used anywhere. Remove related files as well, they were not being
built anyway.
* Disable some extensions like graphics, crash handler and media
session. Android also disables the graphics and media session ones, and
the crash handler one needs proper support (or just be removed in the
future).
* Use nullptr instead of NULL everywhere.
* Fix some headers.

Bug: 478127016
Bug: 447135715

Author: rakuco

starboard/tvos/shared/BUILD.gn

@@ -141,6 +141,7 @@ static_library("starboard_platform") {
     "storage_internal.mm",
     "storage_open_record.mm",
     "storage_read_record.mm",
+    "system_get_extensions.cc",
     "system_get_number_of_processors.mm",
     "system_get_path.mm",
     "system_get_property.mm",
@@ -174,9 +175,6 @@ static_library("starboard_platform") {
     "//starboard/shared/stub/drm_is_server_certificate_updatable.cc",
     "//starboard/shared/stub/drm_update_server_certificate.cc",
     "//starboard/shared/stub/drm_update_session.cc",
-
-    # TODO: b/470021310 - get the tvOS version of this file to build.
-    "//starboard/shared/stub/system_get_extensions.cc",
   ]
 
   sources -= [

starboard/tvos/shared/configuration.cc

@@ -12,49 +12,60 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#include "starboard/common/log.h"
 #include "starboard/common/string.h"
 #include "starboard/extension/accessibility.h"
-#include "starboard/extension/configuration.h"
 #include "starboard/extension/crash_handler.h"
 #include "starboard/extension/graphics.h"
 #include "starboard/extension/ifa.h"
-#include "starboard/extension/media/player_configuration.h"
 #include "starboard/extension/media_session.h"
 #include "starboard/extension/platform_service.h"
+#include "starboard/extension/player_configuration.h"
 #include "starboard/system.h"
 #include "starboard/tvos/shared/accessibility_extension.h"
-#include "starboard/tvos/shared/configuration.h"
 #include "starboard/tvos/shared/crash_handler.h"
-#include "starboard/tvos/shared/graphics.h"
 #include "starboard/tvos/shared/media/player_configuration.h"
 #include "starboard/tvos/shared/uikit_media_session_client.h"
 
 const void* SbSystemGetExtension(const char* name) {
   if (strcmp(name, kCobaltExtensionGraphicsName) == 0) {
-    return starboard::shared::uikit::GetGraphicsApi();
-  }
-  if (strcmp(name, kCobaltExtensionConfigurationName) == 0) {
-    return starboard::shared::uikit::GetConfigurationApi();
+    // Copied from Android's system_get_extensions.cc:
+    // TODO: b/377052944 - Check if this is needed, likely can be
+    // deleted.
+    // return starboard::GetGraphicsApi();
+    return nullptr;
   }
   if (strcmp(name, kCobaltExtensionMediaSessionName) == 0) {
-    return starboard::shared::uikit::GetMediaSessionApi();
+    // Copied from Android's system_get_extensions.cc:
+    // TODO: b/377019873 - Re-enable
+    // return starboard::GetMediaSessionApi();
+    return nullptr;
   }
   if (strcmp(name, kCobaltExtensionCrashHandlerName) == 0) {
-    return starboard::shared::uikit::GetCrashHandlerApi();
+    // TODO: b/477518757 - Re-enable once Crashpad support is in and if it
+    // needs to be exposed as an extension.
+    // return starboard::GetCrashHandlerApi();
+    return nullptr;
   }
   if (strcmp(name, kCobaltExtensionPlatformServiceName) == 0) {
     SB_LOG(INFO) << "The platform service extension is not supported on tvOS";
     return nullptr;
   }
   if (strcmp(name, kStarboardExtensionIfaName) == 0) {
     SB_LOG(INFO) << "IFA is not supported via Starboard.";
-    return NULL;
+    return nullptr;
   }
   if (strcmp(name, kStarboardExtensionPlayerConfigurationName) == 0) {
-    return starboard::shared::uikit::GetPlayerConfigurationApi();
+    // TODO: b/447334535 - This depends on decode to texture mode being
+    // implemented.
+    // return starboard::GetPlayerConfigurationApi();
+    return nullptr;
   }
   if (strcmp(name, kStarboardExtensionAccessibilityName) == 0) {
-    return starboard::shared::uikit::GetAccessibilityApi();
+    // TODO: b/478127016 - This will be enabled separately with the rest of
+    // VoiceOver support code.
+    // return starboard::GetAccessibilityApi();
+    return nullptr;
   }
-  return NULL;
+  return nullptr;
 }