Skip to content

Commit 9a784b0

Browse files
committed
metrics: Fix experimental memory histogram naming hierarchical structure
1 parent 5e4032d commit 9a784b0

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

cobalt/browser/metrics/cobalt_memory_metrics_emitter.cc

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -64,31 +64,31 @@ const CobaltMemoryMetricsEmitter::Metric kAllocatorDumpNamesForMetrics[] = {
6464
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
6565
{}},
6666
{"blink_objects/Document",
67-
"NumberOfDocuments",
67+
"Tiny.NumberOfDocuments",
6868
CobaltMemoryMetricsEmitter::MetricSize::kTiny,
6969
MemoryAllocatorDump::kNameObjectCount,
7070
CobaltMemoryMetricsEmitter::EmitTo::kCountsInUkmAndSizeInUma,
7171
{}},
7272
{"blink_objects/Frame",
73-
"NumberOfFrames",
73+
"Tiny.NumberOfFrames",
7474
CobaltMemoryMetricsEmitter::MetricSize::kTiny,
7575
MemoryAllocatorDump::kNameObjectCount,
7676
CobaltMemoryMetricsEmitter::EmitTo::kCountsInUkmAndSizeInUma,
7777
{}},
7878
{"blink_objects/LayoutObject",
79-
"NumberOfLayoutObjects",
79+
"Tiny.NumberOfLayoutObjects",
8080
CobaltMemoryMetricsEmitter::MetricSize::kTiny,
8181
MemoryAllocatorDump::kNameObjectCount,
8282
CobaltMemoryMetricsEmitter::EmitTo::kCountsInUkmAndSizeInUma,
8383
{}},
8484
{"blink_objects/Node",
85-
"NumberOfNodes",
85+
"Small.NumberOfNodes",
8686
CobaltMemoryMetricsEmitter::MetricSize::kSmall,
8787
MemoryAllocatorDump::kNameObjectCount,
8888
CobaltMemoryMetricsEmitter::EmitTo::kCountsInUkmAndSizeInUma,
8989
{}},
9090
{"font_caches/shape_caches",
91-
"FontCaches",
91+
"Small.FontCaches",
9292
CobaltMemoryMetricsEmitter::MetricSize::kSmall,
9393
"size",
9494
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
@@ -100,7 +100,7 @@ const CobaltMemoryMetricsEmitter::Metric kAllocatorDumpNamesForMetrics[] = {
100100
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
101101
{}},
102102
{"leveldatabase",
103-
"LevelDatabase",
103+
"Small.LevelDatabase",
104104
CobaltMemoryMetricsEmitter::MetricSize::kSmall,
105105
kEffectiveSize,
106106
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
@@ -136,19 +136,19 @@ const CobaltMemoryMetricsEmitter::Metric kAllocatorDumpNamesForMetrics[] = {
136136
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
137137
{}},
138138
{"skia/sk_glyph_cache",
139-
"Skia.SkGlyphCache",
139+
"Skia.Small.SkGlyphCache",
140140
CobaltMemoryMetricsEmitter::MetricSize::kSmall,
141141
"size",
142142
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
143143
{}},
144144
{"sqlite",
145-
"Sqlite",
145+
"Small.Sqlite",
146146
CobaltMemoryMetricsEmitter::MetricSize::kSmall,
147147
kEffectiveSize,
148148
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
149149
{}},
150150
{"ui",
151-
"UI",
151+
"Small.UI",
152152
CobaltMemoryMetricsEmitter::MetricSize::kSmall,
153153
kEffectiveSize,
154154
CobaltMemoryMetricsEmitter::EmitTo::kSizeInUkmAndUma,
@@ -177,8 +177,8 @@ const CobaltMemoryMetricsEmitter::Metric kAllocatorDumpNamesForMetrics[] = {
177177

178178
constexpr char kExperimentalUmaPrefix[] = "Memory.Experimental.";
179179
constexpr char kVersionSuffixNormal[] = "2.";
180-
constexpr char kVersionSuffixSmall[] = "2.Small.";
181-
constexpr char kVersionSuffixTiny[] = "2.Tiny.";
180+
constexpr char kVersionSuffixSmall[] = "2.";
181+
constexpr char kVersionSuffixTiny[] = "2.";
182182

183183
static const char* MetricSizeToVersionSuffix(
184184
CobaltMemoryMetricsEmitter::MetricSize size) {

cobalt/browser/metrics/font_metrics_browsertest.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ IN_PROC_BROWSER_TEST_F(FontMetricsBrowserTest, RecordsFontHistograms) {
9191
.size(),
9292
1u);
9393

94-
EXPECT_GE(
95-
histogram_tester.GetAllSamples("Memory.Experimental.Browser2.FontCaches")
96-
.size(),
97-
1u);
94+
EXPECT_GE(histogram_tester
95+
.GetAllSamples("Memory.Experimental.Browser2.Small.FontCaches")
96+
.size(),
97+
1u);
9898
}
9999

100100
} // namespace cobalt

0 commit comments

Comments
 (0)